-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
REFACTOR: Improve readability vulnerability handling #5579
REFACTOR: Improve readability vulnerability handling #5579
Conversation
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
For more information, see https://pre-commit.ci
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5579 +/- ##
==========================================
- Coverage 85.27% 85.27% -0.01%
==========================================
Files 152 152
Lines 60990 60937 -53
==========================================
- Hits 52011 51964 -47
+ Misses 8979 8973 -6 |
4afe5d0
to
66868c4
Compare
For more information, see https://pre-commit.ci
@Samuelopez-ansys @gmalinve If one of you has some time, please have a look at this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some comments that could improve the readability of some parts of code.
Overall LGTM!
@SMoraisAnsys Could we merge this PR? |
Let me perform Giulia's changes and it will be okay :) |
ad0fbbd
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Improve readability and vulnerability handling.
Issue linked
Contributes to #5504 and #4666