Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REFACTOR: Improve readability vulnerability handling #5579

Merged

Conversation

SMoraisAnsys
Copy link
Collaborator

@SMoraisAnsys SMoraisAnsys commented Dec 16, 2024

Description

Improve readability and vulnerability handling.

Issue linked

Contributes to #5504 and #4666

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

Copy link

codecov bot commented Dec 16, 2024

Codecov Report

Attention: Patch coverage is 84.00000% with 12 lines in your changes missing coverage. Please review.

Project coverage is 85.27%. Comparing base (a457727) to head (ad0fbbd).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5579      +/-   ##
==========================================
- Coverage   85.27%   85.27%   -0.01%     
==========================================
  Files         152      152              
  Lines       60990    60937      -53     
==========================================
- Hits        52011    51964      -47     
+ Misses       8979     8973       -6     

@SMoraisAnsys SMoraisAnsys marked this pull request as draft December 20, 2024 08:42
@github-actions github-actions bot added the testing Anything related to testing label Jan 2, 2025
@SMoraisAnsys SMoraisAnsys marked this pull request as ready for review January 2, 2025 13:11
@SMoraisAnsys SMoraisAnsys force-pushed the refactor/improve-readibility-vulnerability-handling branch from 4afe5d0 to 66868c4 Compare January 2, 2025 15:25
@SMoraisAnsys
Copy link
Collaborator Author

@Samuelopez-ansys @gmalinve If one of you has some time, please have a look at this PR.
Most valuable changes are located in spisim.py, modeler_3d.py, rpyc_services.py and touchstone_parser.py

gmalinve
gmalinve previously approved these changes Jan 7, 2025
MaxJPRey
MaxJPRey previously approved these changes Jan 7, 2025
Copy link
Contributor

@gmalinve gmalinve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some comments that could improve the readability of some parts of code.
Overall LGTM!

@Samuelopez-ansys
Copy link
Member

@SMoraisAnsys Could we merge this PR?

@gmalinve gmalinve self-requested a review January 8, 2025 08:17
@SMoraisAnsys
Copy link
Collaborator Author

par_description

Let me perform Giulia's changes and it will be okay :)

Copy link
Member

@Samuelopez-ansys Samuelopez-ansys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Samuelopez-ansys Samuelopez-ansys enabled auto-merge (squash) January 8, 2025 09:25
@Samuelopez-ansys Samuelopez-ansys merged commit b47ea37 into main Jan 8, 2025
42 of 43 checks passed
@Samuelopez-ansys Samuelopez-ansys deleted the refactor/improve-readibility-vulnerability-handling branch January 8, 2025 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Anything related to testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants