Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Edit sources from file in HFSS 3DLayout inversed order #5490

Merged
merged 5 commits into from
Nov 27, 2024

Conversation

Samuelopez-ansys
Copy link
Member

@Samuelopez-ansys Samuelopez-ansys commented Nov 27, 2024

Description

Edit sources from file in HFSS 3DLayout API was inverted.

Issue linked

#5481

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have agreed with the Contributor License Agreement (CLA).

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added the bug Something isn't working label Nov 27, 2024
Copy link

codecov bot commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.68%. Comparing base (7efbd5e) to head (ddaffdb).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5490      +/-   ##
==========================================
+ Coverage   80.76%   84.68%   +3.92%     
==========================================
  Files         143      143              
  Lines       60124    60124              
==========================================
+ Hits        48557    50916    +2359     
+ Misses      11567     9208    -2359     

@Samuelopez-ansys Samuelopez-ansys merged commit b590d97 into main Nov 27, 2024
43 checks passed
@Samuelopez-ansys Samuelopez-ansys deleted the fix/issue_5481 branch November 27, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Push Excitation from transient Toolkit is inverting Mag and phase dataset
2 participants