Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEAT: Use GetDataModel to improve the way information are cached into the API #5488

Merged
merged 26 commits into from
Dec 11, 2024

Conversation

maxcapodi78
Copy link
Collaborator

@maxcapodi78 maxcapodi78 commented Nov 27, 2024

Description

Use GetDataModel to improve the way information are cached into the API. This is gonna be effective mostly in 25R1.

Issue linked

#5487

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have agreed with the Contributor License Agreement (CLA).

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added testing Anything related to testing enhancement New features or code improvements labels Nov 27, 2024
Copy link

codecov bot commented Nov 27, 2024

Codecov Report

Attention: Patch coverage is 85.81006% with 508 lines in your changes missing coverage. Please review.

Project coverage is 85.01%. Comparing base (f0c5a83) to head (5a806c7).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5488      +/-   ##
==========================================
+ Coverage   79.65%   85.01%   +5.36%     
==========================================
  Files         144      151       +7     
  Lines       60628    60761     +133     
==========================================
+ Hits        48291    51658    +3367     
+ Misses      12337     9103    -3234     

@maxcapodi78 maxcapodi78 marked this pull request as draft November 29, 2024 15:35
# Conflicts:
#	src/ansys/aedt/core/modules/boundary.py
#	src/ansys/aedt/core/modules/solve_setup.py
#	tests/system/general/test_41_3dlayout_modeler.py
@maxcapodi78 maxcapodi78 marked this pull request as ready for review December 9, 2024 09:40
Copy link
Member

@Samuelopez-ansys Samuelopez-ansys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! This is just the beginning :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New features or code improvements testing Anything related to testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants