Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEAT: implement resistive sheet #5473

Merged
merged 7 commits into from
Nov 26, 2024
Merged

FEAT: implement resistive sheet #5473

merged 7 commits into from
Nov 26, 2024

Conversation

gmalinve
Copy link
Contributor

No description provided.

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added the enhancement New features or code improvements label Nov 22, 2024
@gmalinve gmalinve linked an issue Nov 22, 2024 that may be closed by this pull request
Copy link

codecov bot commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.68%. Comparing base (91543ea) to head (c3d0f7e).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5473   +/-   ##
=======================================
  Coverage   84.67%   84.68%           
=======================================
  Files         143      143           
  Lines       60082    60110   +28     
=======================================
+ Hits        50875    50904   +29     
+ Misses       9207     9206    -1     

@gmalinve gmalinve marked this pull request as ready for review November 25, 2024 10:44
SMoraisAnsys
SMoraisAnsys previously approved these changes Nov 25, 2024
Copy link
Collaborator

@SMoraisAnsys SMoraisAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I left minor comments

src/ansys/aedt/core/maxwell.py Show resolved Hide resolved
src/ansys/aedt/core/maxwell.py Outdated Show resolved Hide resolved
src/ansys/aedt/core/maxwell.py Show resolved Hide resolved
Co-authored-by: Sébastien Morais <146729917+SMoraisAnsys@users.noreply.github.com>
@github-actions github-actions bot added the testing Anything related to testing label Nov 25, 2024
Copy link
Member

@Samuelopez-ansys Samuelopez-ansys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmalinve gmalinve merged commit cf37ddd into main Nov 26, 2024
43 checks passed
@gmalinve gmalinve deleted the feat/m3d_resistive_sheet branch November 26, 2024 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New features or code improvements testing Anything related to testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Resistive Sheet boundary condition in Maxwell
3 participants