Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Check _object_names_to_ids keys are the same than existing object names #5468

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

Samuelopez-ansys
Copy link
Member

Close #5467

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added the bug Something isn't working label Nov 21, 2024
Copy link
Collaborator

@svandenb-dev svandenb-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Samuelopez-ansys Samuelopez-ansys enabled auto-merge (squash) November 21, 2024 13:54
Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.60%. Comparing base (ca9c7b0) to head (7fbb7bb).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5468      +/-   ##
==========================================
- Coverage   84.61%   84.60%   -0.02%     
==========================================
  Files         143      143              
  Lines       60027    60027              
==========================================
- Hits        50794    50785       -9     
- Misses       9233     9242       +9     
---- 🚨 Try these New Features:

@Samuelopez-ansys Samuelopez-ansys merged commit 3cccdeb into main Nov 21, 2024
43 checks passed
@Samuelopez-ansys Samuelopez-ansys deleted the fix/issue_5467 branch November 21, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Delete dielectric objects failing
3 participants