Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Add template for pull request #5453

Merged
merged 3 commits into from
Nov 26, 2024
Merged

CI: Add template for pull request #5453

merged 3 commits into from
Nov 26, 2024

Conversation

SMoraisAnsys
Copy link
Collaborator

As title says.

On top of helping to clarify the PR changes, objective, scope, ... Contributors are asked to agree with the CLA.

Note: the current CLA part might need some modifications as it should be performed only if someone has never agreed to it and isn't an Ansys employee.

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@SMoraisAnsys
Copy link
Collaborator Author

@MaxJPRey Can you give me your feedback on these changes ? I'd like to know if something new associated to the CLA as been performed or if we could add it to the project's PR template.

@github-actions github-actions bot added the maintenance Package and maintenance related label Nov 20, 2024
Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.67%. Comparing base (91543ea) to head (b2d91bb).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5453      +/-   ##
==========================================
- Coverage   84.67%   84.67%   -0.01%     
==========================================
  Files         143      143              
  Lines       60082    60082              
==========================================
- Hits        50875    50872       -3     
- Misses       9207     9210       +3     

@MaxJPRey
Copy link
Collaborator

@SMoraisAnsys Nothing new yet about the CLA.
The content of this PR is good.

MaxJPRey
MaxJPRey previously approved these changes Nov 21, 2024
@SMoraisAnsys SMoraisAnsys marked this pull request as ready for review November 24, 2024 13:49
@SMoraisAnsys SMoraisAnsys merged commit 3a4b738 into main Nov 26, 2024
43 checks passed
@SMoraisAnsys SMoraisAnsys deleted the ci/add-pr-template branch November 26, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Package and maintenance related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants