Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEAT: Import data table in HFSS solution #5449

Merged
merged 5 commits into from
Nov 20, 2024
Merged

Conversation

Samuelopez-ansys
Copy link
Member

Close #5418
Close #5387

Next step is include it in Circuit and HFSS 3DLayout, but they have a different implementation
Include the postprocessing part

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added the enhancement New features or code improvements label Nov 19, 2024
Copy link

codecov bot commented Nov 19, 2024

Codecov Report

Attention: Patch coverage is 92.72727% with 4 lines in your changes missing coverage. Please review.

Project coverage is 84.40%. Comparing base (0faf928) to head (6233ce2).
Report is 10 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5449   +/-   ##
=======================================
  Coverage   84.39%   84.40%           
=======================================
  Files         140      140           
  Lines       58645    58725   +80     
=======================================
+ Hits        49494    49566   +72     
- Misses       9151     9159    +8     
---- 🚨 Try these New Features:

Copy link
Collaborator

@maxcapodi78 maxcapodi78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Samuelopez-ansys Samuelopez-ansys merged commit ec10570 into main Nov 20, 2024
42 checks passed
@Samuelopez-ansys Samuelopez-ansys deleted the feat/issue_5387 branch November 20, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New features or code improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add DeleteImportData to PyAEDT Add import table data for circuit and hfss.
2 participants