FIX: Modified return statement for sweep_around_axis and sweep_along_path so methods accept lists without creating error messages in AEDT. #5416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…so methods accept lists without creating error messages in AEDT.
2 tasks
|
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5416 +/- ##
==========================================
+ Coverage 84.63% 84.67% +0.04%
==========================================
Files 143 143
Lines 60073 60083 +10
==========================================
+ Hits 50840 50874 +34
+ Misses 9233 9209 -24
|
SMoraisAnsys
requested changes
Nov 14, 2024
There was a problem hiding this comment.
Greath @DaveTwyman this will solve the bug when users pass a list as input!
Could you add tests to ensure that everything works fine ?
Added missing unit test for 'sweep_around_axis'. Improved unit tests 'sweep_along_vector' and 'sweep_along_path' to include sweeping a list of sheets in addition to just sweeping a single sheet.
For more information, see https://pre-commit.ci
gmalinve
reviewed
Nov 21, 2024
gmalinve
reviewed
Nov 22, 2024
Assertions were included in existing unit test. Remove as they are testing methods outside of the scope of the sweep unit test. Co-authored-by: gmalinve <103059376+gmalinve@users.noreply.github.com>
For more information, see https://pre-commit.ci
gmalinve
reviewed
Nov 22, 2024
gmalinve
reviewed
Nov 22, 2024
gmalinve
approved these changes
Nov 22, 2024
SMoraisAnsys
approved these changes
Nov 22, 2024
|
[like] David Twyman reacted to your message:
…________________________________
From: Sébastien Morais ***@***.***>
Sent: Friday, November 22, 2024 1:19:21 PM
To: ansys/pyaedt ***@***.***>
Cc: David Twyman ***@***.***>; State change ***@***.***>
Subject: Re: [ansys/pyaedt] FIX: Modified return statement for sweep_around_axis and sweep_along_path so methods accept lists without creating error messages in AEDT. (PR #5416)
[External Sender]
@SMoraisAnsys approved this pull request.
LGTM, thanks for this contribution @DaveTwyman<https://github.com/DaveTwyman>
—
Reply to this email directly, view it on GitHub<#5416 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AVVIYTGTBWQZ3IKXRI2QPYL2B4VNTAVCNFSM6AAAAABRUPOBLCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDINJUGQZTIOJVGY>.
You are receiving this because you modified the open/close state.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.