Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Trap topology condition update for multiband filters #5266

Merged
merged 3 commits into from
Oct 8, 2024
Merged

FIX: Trap topology condition update for multiband filters #5266

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
340d6f0
FIX: Clear function added to multipleband table
ramin4667 Oct 8, 2024
013447a
FIX: Comments added.
ramin4667 Oct 8, 2024
d886ab0
FIX: Unittest is updated.
ramin4667 Oct 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions _unittest/test_45_FilterSolutions/test_filter/test_multiple_bands_table.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,3 +90,19 @@ def test_remove_row(self):
info.value.args[0]
== "Either no value is set for this band or the rowIndex must be greater than zero and less than row count"
)

def test_clear_table(self):
design = ansys.aedt.core.FilterSolutions(implementation_type=FilterImplementation.LUMPED)
ramin4667 marked this conversation as resolved.
Show resolved Hide resolved
design.attributes.filter_multiple_bands_enabled = True
# There are 2 rows in the table by default
assert design.multiple_bands_table.row_count == 2
design.multiple_bands_table.clear_table()
assert design.multiple_bands_table.row_count == 0
# Check if the table is empty for all 7 rows
for i in range(7):
with pytest.raises(RuntimeError) as info:
design.multiple_bands_table.row(i)
assert (
info.value.args[0] == "Either no value is set for this band or the rowIndex must be greater than "
"zero and less than row count"
)
14 changes: 7 additions & 7 deletions _unittest/test_45_FilterSolutions/test_filter/test_transmission_zeros.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,13 +69,13 @@ def test_append_row(self):
assert info.value.args[0] == self.input_value_blank_msg
design.transmission_zeros_bandwidth.append_row("1600M")
assert design.transmission_zeros_bandwidth.row(0) == ("1600M", "")
design.transmission_zeros_bandwidth.clear_row()
design.transmission_zeros_bandwidth.clear_table()
design.transmission_zeros_bandwidth.append_row(zero="1600M", position="2")
assert design.transmission_zeros_bandwidth.row(0) == ("1600M", "2")
design.transmission_zeros_bandwidth.clear_row()
design.transmission_zeros_bandwidth.clear_table()
design.transmission_zeros_ratio.append_row("1.6")
assert design.transmission_zeros_ratio.row(0) == ("1.6", "")
design.transmission_zeros_ratio.clear_row()
design.transmission_zeros_ratio.clear_table()
design.transmission_zeros_ratio.append_row(zero="1.6", position="2")
assert design.transmission_zeros_ratio.row(0) == ("1.6", "2")

Expand All @@ -97,7 +97,7 @@ def test_insert_row(self):
assert design.transmission_zeros_bandwidth.row(0) == ("1600M", "")
design.transmission_zeros_bandwidth.insert_row(0, zero="1600M", position="2")
assert design.transmission_zeros_bandwidth.row(0) == ("1600M", "2")
design.transmission_zeros_bandwidth.clear_row()
design.transmission_zeros_bandwidth.clear_table()
design.transmission_zeros_ratio.insert_row(0, "1.6")
assert design.transmission_zeros_ratio.row(0) == ("1.6", "")
design.transmission_zeros_ratio.insert_row(0, zero="1.6", position="2")
Expand All @@ -114,17 +114,17 @@ def test_remove_row(self):
design.transmission_zeros_bandwidth.row(0)
assert info.value.args[0] == self.no_transmission_zero_msg

def test_clear_row(self):
def test_clear_table(self):
design = ansys.aedt.core.FilterSolutions(implementation_type=FilterImplementation.LUMPED)
design.transmission_zeros_bandwidth.insert_row(0, zero="1600M", position="2")
assert design.transmission_zeros_bandwidth.row(0) == ("1600M", "2")
design.transmission_zeros_bandwidth.clear_row()
design.transmission_zeros_bandwidth.clear_table()
with pytest.raises(RuntimeError) as info:
design.transmission_zeros_bandwidth.row(0)
assert info.value.args[0] == self.no_transmission_zero_msg
design.transmission_zeros_ratio.insert_row(0, zero="1.6", position="2")
assert design.transmission_zeros_ratio.row(0) == ("1.6", "2")
design.transmission_zeros_ratio.clear_row()
design.transmission_zeros_ratio.clear_table()
with pytest.raises(RuntimeError) as info:
design.transmission_zeros_ratio.row(0)
assert info.value.args[0] == self.no_transmission_zero_msg
Expand Down
5 changes: 5 additions & 0 deletions src/ansys/aedt/core/filtersolutions_core/multiple_bands_table.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,3 +166,8 @@ def remove_row(self, row_index):
"""
status = self._dll.removeMultipleBandsTableRow(row_index)
ansys.aedt.core.filtersolutions_core._dll_interface().raise_error(status)

def clear_table(self):
"""Remove all rows from the multiple bands table."""
for i in range(self.row_count - 1, -1, -1):
self.remove_row(i)
2 changes: 1 addition & 1 deletion src/ansys/aedt/core/filtersolutions_core/transmission_zeros.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,7 +241,7 @@ def remove_row(self, row_index):
status = self._dll.removeTransmissionZerosTableRow(row_index, self.table_format_to_bool())
ansys.aedt.core.filtersolutions_core._dll_interface().raise_error(status)

def clear_row(self):
def clear_table(self):
"""Clear all entries in the transmission zeros table."""
status = self._dll.clearTransmissionZerosTableRow(self.table_format_to_bool())
ansys.aedt.core.filtersolutions_core._dll_interface().raise_error(status)
Expand Down
Loading