Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REFACTOR: Cleanup bandit warnings #4962

Merged
merged 3 commits into from
Jul 30, 2024
Merged

REFACTOR: Cleanup bandit warnings #4962

merged 3 commits into from
Jul 30, 2024

Conversation

SMoraisAnsys
Copy link
Collaborator

As title says.

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

Copy link

codecov bot commented Jul 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.45%. Comparing base (b0f022b) to head (955c7f8).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4962      +/-   ##
==========================================
+ Coverage   82.26%   83.45%   +1.19%     
==========================================
  Files         120      120              
  Lines       54561    54558       -3     
==========================================
+ Hits        44886    45533     +647     
+ Misses       9675     9025     -650     

@Samuelopez-ansys
Copy link
Member

@SMoraisAnsys I would add some pragma no cover in some of the exceptions because some of them can not be reached.

@MaxJPRey
Copy link
Collaborator

Thanks @SMoraisAnsys for those improvement.

@SMoraisAnsys SMoraisAnsys enabled auto-merge (squash) July 30, 2024 11:43
@SMoraisAnsys SMoraisAnsys changed the title CHORE: Cleanup bandit warnings REFACTOR: Cleanup bandit warnings Jul 30, 2024
@SMoraisAnsys SMoraisAnsys disabled auto-merge July 30, 2024 11:44
@SMoraisAnsys SMoraisAnsys enabled auto-merge (squash) July 30, 2024 11:44
@SMoraisAnsys SMoraisAnsys merged commit a3db880 into main Jul 30, 2024
46 checks passed
@SMoraisAnsys SMoraisAnsys deleted the chore/cleanup-code branch July 30, 2024 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants