Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REFACTOR: Refacto args #4929

Merged
merged 13 commits into from
Jul 23, 2024
Merged

REFACTOR: Refacto args #4929

merged 13 commits into from
Jul 23, 2024

Conversation

gmalinve
Copy link
Contributor

No description provided.

@gmalinve gmalinve self-assigned this Jul 17, 2024
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added the examples Anything related to the examples label Jul 17, 2024
@gmalinve gmalinve changed the title Refacto args REFACTOR: Refacto args Jul 17, 2024
@gmalinve gmalinve added maintenance Package and maintenance related and removed examples Anything related to the examples labels Jul 17, 2024
@gmalinve gmalinve added this to the v1.0 milestone Jul 17, 2024
Copy link

codecov bot commented Jul 17, 2024

Codecov Report

Attention: Patch coverage is 93.00000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 83.43%. Comparing base (af937c3) to head (1e04d75).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4929      +/-   ##
==========================================
+ Coverage   78.95%   83.43%   +4.47%     
==========================================
  Files         120      120              
  Lines       54458    54458              
==========================================
+ Hits        42999    45435    +2436     
+ Misses      11459     9023    -2436     

@github-actions github-actions bot added the examples Anything related to the examples label Jul 18, 2024
@gmalinve gmalinve changed the title REFACTOR: Refacto args REFACTOR : Refacto args Jul 18, 2024
@gmalinve gmalinve marked this pull request as ready for review July 18, 2024 14:58
@gmalinve gmalinve changed the title REFACTOR : Refacto args REFACTOR: Refacto args Jul 18, 2024
Copy link
Collaborator

@maxcapodi78 maxcapodi78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few comments

_unittest/test_02_3D_modeler.py Outdated Show resolved Hide resolved
examples/04-Icepak/Icepak_3DComponents_Example.py Outdated Show resolved Hide resolved
examples/05-Q3D/Q2D_Example_Stripline.py Outdated Show resolved Hide resolved
@maxcapodi78 maxcapodi78 self-requested a review July 23, 2024 09:03
@maxcapodi78 maxcapodi78 merged commit 5c07bf1 into main Jul 23, 2024
46 checks passed
@maxcapodi78 maxcapodi78 deleted the refacto_args branch July 23, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
examples Anything related to the examples maintenance Package and maintenance related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants