Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: replaced argument output_dir with output_file for method export_field_file #4898

Merged
merged 1 commit into from
Jul 10, 2024

Conversation

Alberto-DM
Copy link
Contributor

replaced argument output_dir with output_file for method export_field_file as it requires to specify a file path, not a dir.

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added the bug Something isn't working label Jul 9, 2024
Copy link

codecov bot commented Jul 9, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 83.16%. Comparing base (a24bfdb) to head (9b2828d).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4898   +/-   ##
=======================================
  Coverage   83.16%   83.16%           
=======================================
  Files         118      118           
  Lines       54143    54143           
=======================================
  Hits        45027    45027           
  Misses       9116     9116           

Copy link
Collaborator

@MaxJPRey MaxJPRey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Alberto-DM Alberto-DM added this to the v1.0 milestone Jul 10, 2024
@Alberto-DM Alberto-DM merged commit 1b8fffb into main Jul 10, 2024
45 of 46 checks passed
@Alberto-DM Alberto-DM deleted the fix/export_field_file_argument branch July 10, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants