Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance docstring+fix backward compatiblity manipulation #4585

Merged
merged 8 commits into from
Apr 26, 2024

Conversation

lorenzovecchietti
Copy link
Contributor

No description provided.

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@codecov-commenter
Copy link

codecov-commenter commented Apr 24, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 81.52%. Comparing base (87739a9) to head (3eb2931).

❗ Current head 3eb2931 differs from pull request most recent head f9ab61b. Consider uploading reports for the commit f9ab61b to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4585      +/-   ##
==========================================
- Coverage   81.52%   81.52%   -0.01%     
==========================================
  Files         110      110              
  Lines       53765    53775      +10     
==========================================
+ Hits        43831    43839       +8     
- Misses       9934     9936       +2     

@lorenzovecchietti lorenzovecchietti marked this pull request as ready for review April 24, 2024 08:26
@lorenzovecchietti lorenzovecchietti marked this pull request as draft April 24, 2024 08:57
Copy link
Member

@Samuelopez-ansys Samuelopez-ansys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lorenzovecchietti lorenzovecchietti marked this pull request as ready for review April 24, 2024 13:40
lorenzovecchietti and others added 3 commits April 24, 2024 17:18
Copy link
Collaborator

@SMoraisAnsys SMoraisAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lorenzovecchietti lorenzovecchietti merged commit 61f1bf2 into main Apr 26, 2024
15 checks passed
@lorenzovecchietti lorenzovecchietti deleted the enhance_create_2d_mesh_region branch April 26, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants