Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REFACT: Clean design solution and circuit #4561

Merged
merged 2 commits into from
Apr 22, 2024

Conversation

SMoraisAnsys
Copy link
Collaborator

As title says.

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@codecov-commenter
Copy link

codecov-commenter commented Apr 21, 2024

Codecov Report

Attention: Patch coverage is 28.57143% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 81.52%. Comparing base (2eb1acd) to head (1faaa5a).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4561      +/-   ##
==========================================
+ Coverage   81.51%   81.52%   +0.01%     
==========================================
  Files         110      110              
  Lines       53745    53746       +1     
==========================================
+ Hits        43811    43818       +7     
+ Misses       9934     9928       -6     

Copy link
Member

@Samuelopez-ansys Samuelopez-ansys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Samuelopez-ansys Samuelopez-ansys merged commit 2615a70 into main Apr 22, 2024
15 checks passed
@Samuelopez-ansys Samuelopez-ansys deleted the refact/clean-design-solution-and-circuit branch April 22, 2024 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants