Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHORE: Do not use pass in an except statement. #4518

Merged
merged 17 commits into from
Apr 18, 2024
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pyaedt/desktop.py
Original file line number Diff line number Diff line change
Expand Up @@ -945,7 +945,7 @@ def _initialize(
self.is_grpc_api = True
last_session.parent_desktop_id.append(self.aedt_process_id)
return True
except:
except Exception:
messages = desktop.GetMessages("", "", 0)
for message in messages:
if " GRPC server running on port: " in message and str(port) in message:
SMoraisAnsys marked this conversation as resolved.
Show resolved Hide resolved
MaxJPRey marked this conversation as resolved.
Show resolved Hide resolved
Expand Down
2 changes: 1 addition & 1 deletion pyaedt/generic/ibis_reader.py
Original file line number Diff line number Diff line change
Expand Up @@ -415,7 +415,7 @@ def add(self):
[],
],
)
except:
except Exception:
logger.error("Error adding {} pin component.".format(self.short_name))
return False

Expand Down
9 changes: 4 additions & 5 deletions pyaedt/hfss.py
Original file line number Diff line number Diff line change
Expand Up @@ -3759,11 +3759,11 @@ def thicken_port_sheets(self, assignment, value, extrude_internally=True, intern
objID = self.modeler.oeditor.GetFaceIDs(el)
faceCenter = self.modeler.oeditor.GetFaceCenter(int(objID[0]))
directionfound = False
l = min(aedt_bounding_dim) / 2
thickness = min(aedt_bounding_dim) / 2
while not directionfound:
self.modeler.oeditor.ThickenSheet(
["NAME:Selections", "Selections:=", el, "NewPartsModelFlag:=", "Model"],
["NAME:SheetThickenParameters", "Thickness:=", str(l) + "mm", "BothSides:=", False],
["NAME:SheetThickenParameters", "Thickness:=", str(thickness) + "mm", "BothSides:=", False],
)
# aedt_bounding_box2 = self.oeditor.GetModelBoundingBox()
aedt_bounding_box2 = self.modeler.get_model_bounding_box()
Expand All @@ -3773,7 +3773,7 @@ def thicken_port_sheets(self, assignment, value, extrude_internally=True, intern
directionfound = True
self.modeler.oeditor.ThickenSheet(
["NAME:Selections", "Selections:=", el, "NewPartsModelFlag:=", "Model"],
["NAME:SheetThickenParameters", "Thickness:=", "-" + str(l) + "mm", "BothSides:=", False],
["NAME:SheetThickenParameters", "Thickness:=", "-" + str(thickness) + "mm", "BothSides:=", False],
)
# aedt_bounding_box2 = self.oeditor.GetModelBoundingBox()
aedt_bounding_box2 = self.modeler.get_model_bounding_box()
Expand All @@ -3784,7 +3784,7 @@ def thicken_port_sheets(self, assignment, value, extrude_internally=True, intern
directions[el] = "Internal"
directionfound = True
else:
l = l + min(aedt_bounding_dim) / 2
thickness = thickness + min(aedt_bounding_dim) / 2
for el in assignment:
objID = self.modeler.oeditor.GetFaceIDs(el)
maxarea = 0
Expand Down Expand Up @@ -3857,7 +3857,6 @@ def thicken_port_sheets(self, assignment, value, extrude_internally=True, intern
)
except Exception:
self.logger.info("done")
# self.modeler_oproject.ClearMessages()
return ports_ID

@pyaedt_function_handler(dname="design", ouputdir="ouput_dir")
Expand Down
20 changes: 10 additions & 10 deletions pyaedt/modeler/cad/Primitives.py
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ def __getitem__(self, item):
o = self.__parent._create_object(name, id)
self.__setitem__(id, o)
return o
except:
except Exception:
raise KeyError(item)

elif isinstance(item, str):
Expand All @@ -147,7 +147,7 @@ def __getitem__(self, item):
o = self.__parent._create_object(name, id)
self.__setitem__(id, o)
return o
except:
except Exception:
raise KeyError(item)

elif isinstance(item, (Object3d, Polyline)):
Expand Down Expand Up @@ -208,7 +208,7 @@ def __getitem__(self, partId):
return partId
try:
return self.objects[partId]
except:
except Exception:
if partId in self.user_defined_components.keys():
return self.user_defined_components[partId]
self.logger.error("Object '{}' not found.".format(partId))
Expand Down Expand Up @@ -846,13 +846,13 @@ def _refresh_all_ids_from_aedt_file(self):
if operations and isinstance(operations.get("Operation", None), (OrderedDict, dict)):
try:
pid = operations["Operation"]["ParentPartID"]
except Exception: # pragma: no cover
pass
except Exception as e: # pragma: no cover
self.logger.error(e)
SMoraisAnsys marked this conversation as resolved.
Show resolved Hide resolved
elif operations and isinstance(operations.get("Operation", None), list):
try:
pid = operations["Operation"][0]["ParentPartID"]
except Exception:
MaxJPRey marked this conversation as resolved.
Show resolved Hide resolved
pass
self.logger.error(e)
SMoraisAnsys marked this conversation as resolved.
Show resolved Hide resolved

is_polyline = False
if operations and "PolylineParameters" in operations.get("Operation", {}):
Expand Down Expand Up @@ -1231,13 +1231,13 @@ def _get_coordinates_data(self): # pragma: no cover
coord.append(FaceCoordinateSystem(self, props, name))
break
except Exception:
MaxJPRey marked this conversation as resolved.
Show resolved Hide resolved
pass
self.logger.error(e)
SMoraisAnsys marked this conversation as resolved.
Show resolved Hide resolved
for cs in coord:
if isinstance(cs, CoordinateSystem):
try:
cs._ref_cs = id2name[name2refid[cs.name]]
except Exception:
pass
except Exception as e:
self.logger.error(e)
SMoraisAnsys marked this conversation as resolved.
Show resolved Hide resolved
coord.reverse()
return coord

Expand Down Expand Up @@ -8275,7 +8275,7 @@ def _create_object(self, name, pid=0, use_cached=False, is_polyline=False, **kwa
except Exception:
self.logger.warning("Unable to assign " + str(k) + " to object " + o.name + ".")
else:
self.logger.error("'" + str(k) + "' is not a valid property of the primitive ")
self.logger.error("'" + str(k) + "' is not a valid property of the primitive.")
SMoraisAnsys marked this conversation as resolved.
Show resolved Hide resolved
return o

@pyaedt_function_handler()
Expand Down
Loading