Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor modeler #4512

Merged
merged 30 commits into from
Apr 18, 2024
Merged

Refactor modeler #4512

merged 30 commits into from
Apr 18, 2024

Conversation

maxcapodi78
Copy link
Collaborator

Refactored all modeler folder named arguments

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@codecov-commenter
Copy link

codecov-commenter commented Apr 17, 2024

Codecov Report

Attention: Patch coverage is 91.09792% with 60 lines in your changes are missing coverage. Please review.

Project coverage is 82.12%. Comparing base (e4153f5) to head (8d41a9f).
Report is 14 commits behind head on main.

❗ Current head 8d41a9f differs from pull request most recent head d1cd5b6. Consider uploading reports for the commit d1cd5b6 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4512      +/-   ##
==========================================
+ Coverage   76.63%   82.12%   +5.49%     
==========================================
  Files         110      109       -1     
  Lines       53560    53157     -403     
==========================================
+ Hits        41044    43657    +2613     
+ Misses      12516     9500    -3016     

@maxcapodi78 maxcapodi78 added this to the v1.0 milestone Apr 18, 2024
@Samuelopez-ansys Samuelopez-ansys merged commit e03436c into main Apr 18, 2024
15 checks passed
@Samuelopez-ansys Samuelopez-ansys deleted the refactor_modeler branch April 18, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants