Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement to parametric heatsink function #4498

Merged
merged 2 commits into from
Apr 15, 2024

Conversation

lorenzovecchietti
Copy link
Contributor

Even if the number of columns is 1, we can leave this as a parameter so that it can be changed down the line

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added the bug Something isn't working label Apr 15, 2024
@codecov-commenter
Copy link

codecov-commenter commented Apr 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.42%. Comparing base (5660dbb) to head (b0c4513).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4498   +/-   ##
=======================================
  Coverage   81.42%   81.42%           
=======================================
  Files         110      110           
  Lines       53510    53508    -2     
=======================================
  Hits        43570    43570           
+ Misses       9940     9938    -2     

@lorenzovecchietti lorenzovecchietti marked this pull request as ready for review April 15, 2024 10:46
Copy link
Collaborator

@SMoraisAnsys SMoraisAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Samuelopez-ansys Samuelopez-ansys merged commit 0e5949f into main Apr 15, 2024
15 checks passed
@Samuelopez-ansys Samuelopez-ansys deleted the fix_parametric-heatsink branch April 15, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants