Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

assignment + docstrings - PostProcessor refacto #4480

Merged
merged 5 commits into from
Apr 11, 2024
Merged

assignment + docstrings - PostProcessor refacto #4480

merged 5 commits into from
Apr 11, 2024

Conversation

gmalinve
Copy link
Contributor

No description provided.

@gmalinve gmalinve added enhancement New features or code improvements maintenance Package and maintenance related labels Apr 10, 2024
@gmalinve gmalinve added this to the v1.0 milestone Apr 10, 2024
@gmalinve gmalinve self-assigned this Apr 10, 2024
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@codecov-commenter
Copy link

codecov-commenter commented Apr 10, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 94.82759% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 81.42%. Comparing base (e9c7290) to head (7fd4007).

❗ Current head 7fd4007 differs from pull request most recent head 2157b32. Consider uploading reports for the commit 2157b32 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #4480      +/-   ##
==========================================
- Coverage   81.43%   81.42%   -0.01%     
==========================================
  Files         110      110              
  Lines       53482    53482              
==========================================
- Hits        43554    43549       -5     
- Misses       9928     9933       +5

maxcapodi78
maxcapodi78 previously approved these changes Apr 10, 2024
View reviewed changes
gmalinve and others added 3 commits April 11, 2024 12:44
Samuelopez-ansys
Samuelopez-ansys approved these changes Apr 11, 2024
View reviewed changes
Copy link
Member

@Samuelopez-ansys Samuelopez-ansys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Samuelopez-ansys Samuelopez-ansys merged commit 5b9c195 into main Apr 11, 2024
15 checks passed
@Samuelopez-ansys Samuelopez-ansys deleted the post_processor_refacto branch April 11, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PipKat PipKat PipKat left review comments

@Samuelopez-ansys Samuelopez-ansys Samuelopez-ansys approved these changes

@maxcapodi78 maxcapodi78 maxcapodi78 left review comments

@Devin-Crawford Devin-Crawford Awaiting requested review from Devin-Crawford

Assignees

@gmalinve gmalinve

Labels
enhancement New features or code improvements maintenance Package and maintenance related
Projects
None yet
Milestone
v1.0
Development

Successfully merging this pull request may close these issues.
5 participants
@gmalinve @codecov-commenter @maxcapodi78 @PipKat @Samuelopez-ansys