Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not use empty list as parameter's default value. #4397

Merged
merged 2 commits into from
Mar 22, 2024
Merged

Do not use empty list as parameter's default value. #4397

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
11b7367
Do not use empty list as parameter's default value.
MaxJPRey Mar 22, 2024
67fcffd
Merge branch 'main' into maint/empty_lists
MaxJPRey Mar 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions pyaedt/application/Analysis3DLayout.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -340,7 +340,7 @@ def get_next_xtalk_list(self, trlist=[], tx_prefix=""):
return next

@pyaedt_function_handler()
def get_fext_xtalk_list(self, trlist=[], reclist=[], tx_prefix="", rx_prefix="", skip_same_index_couples=True):
def get_fext_xtalk_list(self, trlist=None, reclist=None, tx_prefix="", rx_prefix="", skip_same_index_couples=True):
"""Retrieve a list of all the far end XTalks from two lists of exctitations (driver and receiver).

Parameters
Expand Down Expand Up @@ -371,9 +371,9 @@ def get_fext_xtalk_list(self, trlist=[], reclist=[], tx_prefix="", rx_prefix="",
>>> oModule.GetAllPorts
"""
fext = []
if not trlist:
if trlist is None:
trlist = [i for i in self.excitations if tx_prefix in i]
if not reclist:
if reclist is None:
reclist = [i for i in self.excitations if rx_prefix in i]
for i in trlist:
for k in reclist:
Expand Down
9 changes: 2 additions & 7 deletions pyaedt/application/AnalysisNexxim.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -526,15 +526,10 @@ def get_fext_xtalk_list(self, trlist=None, reclist=None, tx_prefix="", rx_prefix

>>> oEditor.GetAllPorts
"""
if trlist == None:
trlist = []
if reclist == None:
reclist = []

fext = []
if not trlist:
if trlist is None:
trlist = [i for i in list(self.excitations.keys()) if tx_prefix in i]
if not reclist:
if reclist is None:
reclist = [i for i in list(self.excitations.keys()) if rx_prefix in i]
for i in trlist:
for k in reclist:
Expand Down
Loading