Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Created Virtual Compliance example #4322

Merged
merged 12 commits into from
Mar 7, 2024
Merged

Created Virtual Compliance example #4322

merged 12 commits into from
Mar 7, 2024

Conversation

maxcapodi78
Copy link
Collaborator

added method to delete component in circuit
added differential pins AMI Ibis support
added remove_unused_definitions_methods

Created Virtual Compliance example
46b58de 
added method to delete component in circuit
added differential pins AMI Ibis support
added remove_unused_definitions_methods
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@codecov-commenter
Copy link

codecov-commenter commented Mar 6, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 71.25000% with 46 lines in your changes are missing coverage. Please review.

Project coverage is 81.53%. Comparing base (8832950) to head (6a357d3).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #4322      +/-   ##
==========================================
- Coverage   81.56%   81.53%   -0.03%     
==========================================
  Files         107      107              
  Lines       52125    52271     +146     
==========================================
+ Hits        42514    42618     +104     
- Misses       9611     9653      +42

PipKat
PipKat reviewed Mar 6, 2024
View reviewed changes
pyaedt/application/Design.py Outdated Show resolved Hide resolved
PipKat
PipKat reviewed Mar 6, 2024
View reviewed changes
pyaedt/application/Design.py Outdated Show resolved Hide resolved
PipKat
PipKat reviewed Mar 6, 2024
View reviewed changes
pyaedt/hfss3dlayout.py Outdated Show resolved Hide resolved
Samuelopez-ansys
Samuelopez-ansys approved these changes Mar 7, 2024
View reviewed changes
Copy link
Member

@Samuelopez-ansys Samuelopez-ansys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Samuelopez-ansys Samuelopez-ansys merged commit cab62c5 into main Mar 7, 2024
14 checks passed
@Samuelopez-ansys Samuelopez-ansys deleted the virtual_compliance_example branch March 7, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PipKat PipKat PipKat left review comments

@Samuelopez-ansys Samuelopez-ansys Samuelopez-ansys approved these changes

@hui-zhou-a hui-zhou-a Awaiting requested review from hui-zhou-a

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@maxcapodi78 @codecov-commenter @PipKat @Samuelopez-ansys