Avoid python libselinux bindings being hidden by tox #1823
Conversation
713f314 to
710b9c4
Compare
I don't see any addition to the Also, it is unclear to me why you're making a change to our Tox setup here when the original report was about failing to build a docker image. |
There was a problem hiding this comment.
This comment points out that using system site-packages may cause conflicts: #1724 (comment)
tox.ini
Outdated
| # sitepackages=true <- template module <- libselinux bindings which cannot be | ||
| # be installed with pip. Also this lowers virtualenvs footprints and install | ||
| # time | ||
| sitepackages=true |
There was a problem hiding this comment.
wrap it with whitespaces to match the common style
| sitepackages=true | |
| sitepackages = true |
tox.ini
Outdated
| @@ -41,6 +41,10 @@ commands = | |||
| lint: yamllint -s test/ molecule/ | |||
| whitelist_externals = | |||
| find | |||
| # sitepackages=true <- template module <- libselinux bindings which cannot be | |||
There was a problem hiding this comment.
We need to have way more comprehensive explanation then
710b9c4 to
a9f6542
Compare
|
2019-03-13 IRC Meeting. Agreed this isn't 2.20 blocking |
There was a problem hiding this comment.
Please add a detailed explanation as a comment as per https://github.com/ansible/molecule/pull/1823/files#r264877505
|
What information do you feel is missing? The current comment seems quite clear to me. |
|
@fabianvf things tend to seem "obvious" once you already know a lot of details about them. I just want it to become more obvious to a person who has no context, sees it for the first time and tries to acquire such context. "Look at these 100+ comments" is not very helpful here. I think, this kind of comments should follow the same rules/considerations as good commit messages and docstings. |
Avoid akward error during templating of Dockerfile which happens on selinux enabled machines when ansible template module fails due to missing selinux bindings. By using sitepackages=true in tox.ini we likely inherit the libselinux bindings from the system when we create the virtualenvs. Workaround for ansible/ansible#34340 which happens even if selinux is set to permissive. Documents selinux issues in install documentation in order to inform users about what they could encounter. Fixes: #1724 Signed-off-by: Sorin Sbarnea <ssbarnea@redhat.com>
a9f6542 to
33c393d
Compare
|
I'm not sure how many people would be building context from the tox.ini. I think it would be much more helpful to add a section to the docs explaining why Molecule doesn't work well in a normal virtualenv on Fedora-based distributions. If we wanted we could then link to it from here as well. |
Adds libselinux python extensions to the default Dockerfile template
used by molecule in order to avoid failure to build it on selinux
systems.
Fixes: #1724
Signed-off-by: Sorin Sbarnea ssbarnea@redhat.com