Do not allow user to attempt to delete a running job #9758
Conversation
| @@ -238,6 +238,13 @@ function JobList({ i18n, defaultParams, showTypeColumn = false }) { | |||
| onDelete={handleJobDelete} | |||
| itemsToDelete={selected} | |||
| pluralizedItemName={i18n._(t`Jobs`)} | |||
| cannotDelete={item => | |||
| item.status === 'running' || | |||
There was a problem hiding this comment.
There's probably more than one status we'll need to check for. Let's use the isJobRunning util: https://github.com/ansible/awx/blob/devel/awx/ui_next/src/util/jobs.js#L10
There was a problem hiding this comment.
I will also try to use the plural for the error message.
There was a problem hiding this comment.
@jakemcdermott, updated.
|
Build succeeded.
|
|
Build succeeded.
|
| @@ -238,6 +240,19 @@ function JobList({ i18n, defaultParams, showTypeColumn = false }) { | |||
| onDelete={handleJobDelete} | |||
| itemsToDelete={selected} | |||
| pluralizedItemName={i18n._(t`Jobs`)} | |||
| cannotDelete={item => | |||
There was a problem hiding this comment.
Since pluralization can be complicated its best to use this syntax.
Once we upgrade Lingui we will adopt <Plural/>
There was a problem hiding this comment.
@AlexSCorey, I saw this syntax. And I attempted to use it. But the string reported during unit-tests was not sane. I will take a better look if I missed something.
|
Build succeeded.
|
Do not allow user to attempt to delete a running job See: ansible#9187
|
Build succeeded.
|
|
Build succeeded (gate pipeline).
|
Do not allow user to attempt to delete a running job
See: #9187