Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the RBAC for attaching an EE to various objects #9523

Merged
merged 1 commit into from
Mar 11, 2021
Merged

Fix the RBAC for attaching an EE to various objects #9523

merged 1 commit into from
Mar 11, 2021

Conversation

jbradberry
Copy link
Contributor

SUMMARY

It turns out that we were able to attach Org-specific execution environments to various objects when we wouldn't be able to otherwise see the EEs in question:

  • Organization.default_environment
  • Project.default_environment
  • JobTemplate.execution_environment
  • WorkflowJobTemplate.execution_environment

System jobs are not editable by anyone other than a system admin, so
we don't need to check. It appears that unified job templates can't
be created or edited outside of the endpoints for the specific types.

related #9518

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME
  • API
AWX VERSION
awx: 17.0.1

@jbradberry jbradberry self-assigned this Mar 8, 2021
@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

- Organization.default_environment
- Project.default_environment
- JobTemplate.execution_environment
- WorkflowJobTemplate.execution_environment

System jobs are not editable by anyone other than a system admin, so
we don't need to check.  It appears that unified job templates can't
be created or edited outside of the endpoints for the specific types.
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 27c56d4 into ansible:devel Mar 11, 2021
@jbradberry jbradberry deleted the ee-association-rbac branch March 11, 2021 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants