Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve / re-add execution environment list to Organizations #9384

Merged
merged 2 commits into from
Feb 22, 2021
Merged

Resolve / re-add execution environment list to Organizations #9384

merged 2 commits into from
Feb 22, 2021

Conversation

jakemcdermott
Copy link
Contributor

This is actually from #8337

I just rebased, picked the commit, resolved the conflicts. I believe this should do it.

nixocio
nixocio approved these changes Feb 22, 2021
View reviewed changes
Copy link
Contributor

@nixocio nixocio left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jakemcdermott, I left minor suggestions that we can add later or on this PR.

@nixocio @jakemcdermott
Add execution environment list to Organizations
dd016ab 
Add execution environment list to Organizations

See: ansible#8210
rebeccahhh
rebeccahhh approved these changes Feb 22, 2021
View reviewed changes
Copy link
Member

@rebeccahhh rebeccahhh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch :)

shanemcd
shanemcd approved these changes Feb 22, 2021
View reviewed changes
Copy link
Member

@shanemcd shanemcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if tests pass!

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

This was referenced Feb 22, 2021
Merged
Closed
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 4d2f53e into ansible:execution-environments Feb 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shanemcd shanemcd shanemcd approved these changes

@nixocio nixocio nixocio approved these changes

@rebeccahhh rebeccahhh rebeccahhh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jakemcdermott @shanemcd @nixocio @rebeccahhh