Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix setting toggle on click behavior #9093

Merged
merged 2 commits into from
Jan 26, 2021
Merged

Fix setting toggle on click behavior #9093

merged 2 commits into from
Jan 26, 2021

Conversation

marshmalien
Copy link
Member

@marshmalien marshmalien commented Jan 15, 2021 •
edited
Loading

SUMMARY

This PR fixes a bug where the setting toggle value did not change on click. The form group used the same id attr value as the form label and input which conflicted with the label control. To fix this, I updated the form group id to be different from the form label and input.

toggle bug

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME
  • UI

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

@unlikelyzero unlikelyzero self-assigned this Jan 18, 2021
jlmitch5
jlmitch5 approved these changes Jan 18, 2021
View reviewed changes
Copy link
Contributor

@jlmitch5 jlmitch5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@marshmalien marshmalien force-pushed the fix-setting-toggle-id branch from a7093bf to 79e1046 Compare January 21, 2021 17:49
@marshmalien marshmalien force-pushed the fix-setting-toggle-id branch from 79e1046 to ee59ac9 Compare January 21, 2021 17:50
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

@unlikelyzero unlikelyzero mentioned this pull request Jan 26, 2021
Merged
@unlikelyzero
Copy link

Added coverage here https://github.com/ansible/tower-qa/pull/5901

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 3194690 into ansible:devel Jan 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlmitch5 jlmitch5 jlmitch5 approved these changes

Assignees

@unlikelyzero unlikelyzero

Labels
component:ui qe:regression it used to work type:bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@marshmalien @unlikelyzero @jlmitch5 @ryanpetrello @jakemcdermott