Add support for credential password prompting on job launch #9028
Conversation
|
Build succeeded.
|
| label={ | ||
| credId === '' | ||
| ? i18n._(t`Vault password`) | ||
| : i18n._(t`Vault password - ${credId}`) |
There was a problem hiding this comment.
In this PR #8738 we are using | to separate the credential name from the vault ID. I realize this is not exactly the same use case/situation, but thought I'd share. We may want to have some consistency with the naming pattern with these credentials.
| ) { | ||
| launchConfig.passwords_needed_to_start.forEach(password => { | ||
| if (password === 'ssh_password') { | ||
| initialValues.credentialPasswordSsh = ''; |
There was a problem hiding this comment.
Why are we added they keys here, only to switch them back to keys that the api recognizes in https://github.com/ansible/awx/pull/9028/files#diff-b4b7e4b3882a0650f7db64d9166a39cc1c7ecae225a73f41efaaa9bc0334286fR1? It seems that if we didn't switch keys a lot of the validation could be consolidated into a forEach loop making this code more concise and easier to read.
| @@ -0,0 +1,29 @@ | |||
| export default function getCredentialPasswords(values) { | |||
There was a problem hiding this comment.
This could possibly be shortened or maybe even eliminated if we can avoid created keys in the formik values object that the api doesn't recognize.
Full Flow: Note that, when I launch the JT for the first time, the
|
44c68c2 to
fb62e0e
Compare
|
Build succeeded.
|
|
Build succeeded.
|
There was a problem hiding this comment.
Verified that:
- POL regression
- The user can prompt credentials without POL on credential
- The user can prompt credentials with POL on credential
- The user can prompt using different credentials like machine and vault
- The user can relaunch a job and prompt credentials fields
PR with stubs and a test https://github.com/ansible/tower-qa/pull/5871
|
Build succeeded.
|
|
Build succeeded (gate pipeline).
|
SUMMARY
link #7015
The main problem that I ran in to while adding support for this feature is the fact that each time formik's validation runs, errors for fields that are not shown get wiped. To get around this, I added a method to each step that will re-apply errors whenever a user navigates to a particular step. Each step is also responsible for determining whether or not that step has an error.
The scope of these changes will require us to re-test all of the launch prompting scenarios. As far as credentials go, there are 3 scenarios where credential passwords.
Note that this issue: #8200 is still not implemented.
#8921 is also not implemented.
Both of these issues may be encountered during testing.
ISSUE TYPE
COMPONENT NAME