Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix quoting and indentation for management Pod annotations #8873

Closed
wants to merge 1 commit into from

Conversation

hjkatz
Copy link
Contributor

@hjkatz hjkatz commented Dec 11, 2020

SUMMARY

This was missed as part of #8758

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME
  • Installer
AWX VERSION
16.0.0

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

@hjkatz
Copy link
Contributor Author

hjkatz commented Jan 29, 2021

@shanemcd Could I have a hand re-triggering the ansible/gate check? This still exists in 17.0.1 and requires a manual change on our end to deploy the management Pod to k8s.

@ryanpetrello
Copy link
Contributor

@hjkatz sorry for the delay on reviewing this PR - we've in the process of replacing the k8s installer in devel (https://groups.google.com/g/awx-project/c/47MjWSUQaOc/m/bCjSDn0eBQAJ https://github.com/ansible/awx/tree/devel/tools/docker-compose) and thus the next major release of AWX with an operator (https://github.com/ansible/awx-operator), so I suspect this PR is obsolete now.

@hjkatz
Copy link
Contributor Author

hjkatz commented Mar 16, 2021

Until the time comes where the awx-operator is the recommended way of installing AWX, could we please have this PR merged so we can upgrade/install as needed with the AWX versions y'all release?

@ryanpetrello
Copy link
Contributor

@hjkatz,

The next release of AWX will be the operator-based install method - ./installer doesn't exist in the AWX devel source tree anymore at this point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants