Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NodeJS: Bump to actively maintained LTS 14.15.1 #8766

Merged

Conversation

Spredzy
Copy link
Contributor

@Spredzy Spredzy commented Dec 7, 2020

SUMMARY

This change aims to bump the version of NodeJS being used in the ansible/awx project.

Current version used, NodeJS 10 is soon getting to EOL.

Screenshot_2020-12-07 Releases Node js

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME
  • UI
AWX VERSION
  • devel
ADDITIONAL INFORMATION
  • N/A

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

@jakemcdermott
Copy link
Contributor

Looks great @Spredzy !

Few areas where it isn't clear to me if an upgrade was needed.
Should the $PATH here (https://github.com/ansible/awx/blob/devel/installer/roles/image_build/templates/Dockerfile.j2#L244) be updated to ensure it's properly using 14.15.1 ?

We don't need to change that (it's for psql)

Should the following files be updated to reflect new path ?

No need - these are just mock test data.

@@ -3,7 +3,7 @@
"version": "0.1.0",
"private": true,
"engines": {
"node": "10.x"
"node": "14.x"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@unlikelyzero
Copy link

https://github.com/ansible/aap-qa/blob/6edbdd6b268c2debeb1540fad2d310ed9ad0734c/jenkinsfiles/patternfly-e2e.groovy#L234 will need to be tested and modified before merge

@unlikelyzero unlikelyzero added the type:feature prioritized on a feature board label Dec 7, 2020
@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

@unlikelyzero unlikelyzero self-requested a review December 7, 2020 17:25
@unlikelyzero
Copy link

🟢

@Spredzy
Copy link
Contributor Author

Spredzy commented Dec 7, 2020

recheck

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

@jakemcdermott
Copy link
Contributor

recheck

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

@Spredzy
Copy link
Contributor Author

Spredzy commented Dec 7, 2020

recheck

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

@Spredzy
Copy link
Contributor Author

Spredzy commented Dec 8, 2020

recheck

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit be08e0c into ansible:devel Dec 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature prioritized on a feature board
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants