Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix extra GET requests on Notif Template/Container Groups forms #8232

Merged
merged 2 commits into from
Sep 25, 2020
Merged

Fix extra GET requests on Notif Template/Container Groups forms #8232

merged 2 commits into from
Sep 25, 2020

Conversation

mabashian
Copy link
Member

SUMMARY

link #8219

I also hooked up autopopulate on those two forms because that was what was causing the issue. onChange functions that get passed to lookups with autopopulate functionality now have to be wrapped in useCallback to stop them from being redefined on every render.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME
  • UI

@mabashian
Wrap onChange functions passed to lookups in useCallback since these …
24a4236 
…functions are eventually passed to a hook and used in a dependency array.
@mabashian
Autopopulate credential on container group form and organization on n…
56ed2c6 
…otification template form
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

jakemcdermott
jakemcdermott approved these changes Sep 25, 2020
View reviewed changes
Copy link
Contributor

@jakemcdermott jakemcdermott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code changes look reasonable to me. If QE can confirm that we've resolved the issue in all of our forms then let's go ahead and merge this.

@tiagodread tiagodread self-assigned this Sep 25, 2020
tiagodread
tiagodread approved these changes Sep 25, 2020
View reviewed changes
Copy link
Contributor

@tiagodread tiagodread left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran notification templates tests and now everything is ok!

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit b4d6270 into ansible:devel Sep 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakemcdermott jakemcdermott jakemcdermott approved these changes

@tiagodread tiagodread tiagodread approved these changes

Assignees

@tiagodread tiagodread

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mabashian @jakemcdermott @tiagodread