-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update usage of summary_fields for execution environments #8217
Merged
jakemcdermott
merged 1 commit into
ansible:execution-environments
from
nixocio:ui_fix_ee_edit
Sep 23, 2020
Merged
Update usage of summary_fields for execution environments #8217
jakemcdermott
merged 1 commit into
ansible:execution-environments
from
nixocio:ui_fix_ee_edit
Sep 23, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update usage of summary_fields for execution environments. Also, update unit-tests to cover this change. See: ansible#8216
nixocio
commented
Sep 23, 2020
@@ -14,11 +14,11 @@ import { t } from '@lingui/macro'; | |||
import AlertModal from '../AlertModal'; | |||
import { KebabifiedContext } from '../../contexts/Kebabified'; | |||
|
|||
const requireNameOrUsername = props => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
EE does not have the name
field. That is why I decided to rename this function.
jakemcdermott
approved these changes
Sep 23, 2020
jakemcdermott
approved these changes
Sep 23, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 lgtm
jbradberry
pushed a commit
that referenced
this pull request
Sep 25, 2020
Update usage of summary_fields for execution environments. Also, update unit-tests to cover this change. See: #8216
jbradberry
pushed a commit
that referenced
this pull request
Sep 30, 2020
Update usage of summary_fields for execution environments. Also, update unit-tests to cover this change. See: #8216
jbradberry
pushed a commit
that referenced
this pull request
Oct 6, 2020
Update usage of summary_fields for execution environments. Also, update unit-tests to cover this change. See: #8216
shanemcd
pushed a commit
to shanemcd/awx
that referenced
this pull request
Oct 15, 2020
Update usage of summary_fields for execution environments. Also, update unit-tests to cover this change. See: ansible#8216
shanemcd
pushed a commit
that referenced
this pull request
Oct 23, 2020
Update usage of summary_fields for execution environments. Also, update unit-tests to cover this change. See: #8216
shanemcd
pushed a commit
that referenced
this pull request
Oct 27, 2020
Update usage of summary_fields for execution environments. Also, update unit-tests to cover this change. See: #8216
shanemcd
pushed a commit
to shanemcd/awx
that referenced
this pull request
Nov 13, 2020
Update usage of summary_fields for execution environments. Also, update unit-tests to cover this change. See: ansible#8216
jbradberry
pushed a commit
that referenced
this pull request
Nov 13, 2020
Update usage of summary_fields for execution environments. Also, update unit-tests to cover this change. See: #8216
shanemcd
pushed a commit
that referenced
this pull request
Nov 19, 2020
Update usage of summary_fields for execution environments. Also, update unit-tests to cover this change. See: #8216
shanemcd
pushed a commit
that referenced
this pull request
Nov 23, 2020
Update usage of summary_fields for execution environments. Also, update unit-tests to cover this change. See: #8216
shanemcd
pushed a commit
that referenced
this pull request
Nov 23, 2020
Update usage of summary_fields for execution environments. Also, update unit-tests to cover this change. See: #8216
shanemcd
pushed a commit
that referenced
this pull request
Nov 30, 2020
Update usage of summary_fields for execution environments. Also, update unit-tests to cover this change. See: #8216
shanemcd
pushed a commit
that referenced
this pull request
Nov 30, 2020
Update usage of summary_fields for execution environments. Also, update unit-tests to cover this change. See: #8216
shanemcd
pushed a commit
that referenced
this pull request
Nov 30, 2020
Update usage of summary_fields for execution environments. Also, update unit-tests to cover this change. See: #8216
shanemcd
pushed a commit
that referenced
this pull request
Dec 1, 2020
Update usage of summary_fields for execution environments. Also, update unit-tests to cover this change. See: #8216
shanemcd
pushed a commit
that referenced
this pull request
Dec 3, 2020
Update usage of summary_fields for execution environments. Also, update unit-tests to cover this change. See: #8216
shanemcd
pushed a commit
that referenced
this pull request
Dec 3, 2020
Update usage of summary_fields for execution environments. Also, update unit-tests to cover this change. See: #8216
shanemcd
pushed a commit
that referenced
this pull request
Dec 4, 2020
Update usage of summary_fields for execution environments. Also, update unit-tests to cover this change. See: #8216
shanemcd
pushed a commit
that referenced
this pull request
Dec 7, 2020
Update usage of summary_fields for execution environments. Also, update unit-tests to cover this change. See: #8216
jbradberry
pushed a commit
that referenced
this pull request
Dec 10, 2020
Update usage of summary_fields for execution environments. Also, update unit-tests to cover this change. See: #8216
shanemcd
pushed a commit
that referenced
this pull request
Dec 15, 2020
Update usage of summary_fields for execution environments. Also, update unit-tests to cover this change. See: #8216
shanemcd
pushed a commit
that referenced
this pull request
Dec 16, 2020
Update usage of summary_fields for execution environments. Also, update unit-tests to cover this change. See: #8216
shanemcd
pushed a commit
that referenced
this pull request
Jan 4, 2021
Update usage of summary_fields for execution environments. Also, update unit-tests to cover this change. See: #8216
AlanCoding
pushed a commit
to AlanCoding/awx
that referenced
this pull request
Jan 5, 2021
Update usage of summary_fields for execution environments. Also, update unit-tests to cover this change. See: ansible#8216
shanemcd
pushed a commit
that referenced
this pull request
Jan 12, 2021
Update usage of summary_fields for execution environments. Also, update unit-tests to cover this change. See: #8216
shanemcd
pushed a commit
that referenced
this pull request
Jan 14, 2021
Update usage of summary_fields for execution environments. Also, update unit-tests to cover this change. See: #8216
shanemcd
pushed a commit
that referenced
this pull request
Jan 15, 2021
Update usage of summary_fields for execution environments. Also, update unit-tests to cover this change. See: #8216
shanemcd
pushed a commit
that referenced
this pull request
Jan 17, 2021
Update usage of summary_fields for execution environments. Also, update unit-tests to cover this change. See: #8216
shanemcd
pushed a commit
that referenced
this pull request
Jan 20, 2021
Update usage of summary_fields for execution environments. Also, update unit-tests to cover this change. See: #8216
shanemcd
pushed a commit
that referenced
this pull request
Jan 25, 2021
Update usage of summary_fields for execution environments. Also, update unit-tests to cover this change. See: #8216
shanemcd
pushed a commit
that referenced
this pull request
Jan 26, 2021
Update usage of summary_fields for execution environments. Also, update unit-tests to cover this change. See: #8216
shanemcd
pushed a commit
that referenced
this pull request
Jan 29, 2021
Update usage of summary_fields for execution environments. Also, update unit-tests to cover this change. See: #8216
shanemcd
pushed a commit
that referenced
this pull request
Feb 2, 2021
Update usage of summary_fields for execution environments. Also, update unit-tests to cover this change. See: #8216
shanemcd
pushed a commit
that referenced
this pull request
Feb 3, 2021
Update usage of summary_fields for execution environments. Also, update unit-tests to cover this change. See: #8216
shanemcd
pushed a commit
that referenced
this pull request
Feb 7, 2021
Update usage of summary_fields for execution environments. Also, update unit-tests to cover this change. See: #8216
shanemcd
pushed a commit
that referenced
this pull request
Feb 8, 2021
Update usage of summary_fields for execution environments. Also, update unit-tests to cover this change. See: #8216
shanemcd
pushed a commit
that referenced
this pull request
Feb 8, 2021
Update usage of summary_fields for execution environments. Also, update unit-tests to cover this change. See: #8216
shanemcd
pushed a commit
that referenced
this pull request
Feb 9, 2021
Update usage of summary_fields for execution environments. Also, update unit-tests to cover this change. See: #8216
beeankha
pushed a commit
to beeankha/awx
that referenced
this pull request
Feb 12, 2021
Update usage of summary_fields for execution environments. Also, update unit-tests to cover this change. See: ansible#8216
shanemcd
pushed a commit
that referenced
this pull request
Feb 15, 2021
Update usage of summary_fields for execution environments. Also, update unit-tests to cover this change. See: #8216
shanemcd
pushed a commit
that referenced
this pull request
Feb 17, 2021
Update usage of summary_fields for execution environments. Also, update unit-tests to cover this change. See: #8216
shanemcd
pushed a commit
that referenced
this pull request
Feb 18, 2021
Update usage of summary_fields for execution environments. Also, update unit-tests to cover this change. See: #8216
shanemcd
pushed a commit
that referenced
this pull request
Feb 18, 2021
Update usage of summary_fields for execution environments. Also, update unit-tests to cover this change. See: #8216
shanemcd
pushed a commit
that referenced
this pull request
Feb 22, 2021
Update usage of summary_fields for execution environments. Also, update unit-tests to cover this change. See: #8216
shanemcd
pushed a commit
that referenced
this pull request
Feb 22, 2021
Update usage of summary_fields for execution environments. Also, update unit-tests to cover this change. See: #8216
rooftopcellist
pushed a commit
to rooftopcellist/awx
that referenced
this pull request
Feb 23, 2021
Update usage of summary_fields for execution environments. Also, update unit-tests to cover this change. See: ansible#8216
shanemcd
pushed a commit
that referenced
this pull request
Feb 23, 2021
Update usage of summary_fields for execution environments. Also, update unit-tests to cover this change. See: #8216
shanemcd
pushed a commit
that referenced
this pull request
Feb 25, 2021
Update usage of summary_fields for execution environments. Also, update unit-tests to cover this change. See: #8216
shanemcd
pushed a commit
that referenced
this pull request
Mar 1, 2021
Update usage of summary_fields for execution environments. Also, update unit-tests to cover this change. See: #8216
shanemcd
pushed a commit
that referenced
this pull request
Mar 1, 2021
Update usage of summary_fields for execution environments. Also, update unit-tests to cover this change. See: #8216
shanemcd
pushed a commit
that referenced
this pull request
Mar 2, 2021
Update usage of summary_fields for execution environments. Also, update unit-tests to cover this change. See: #8216
shanemcd
pushed a commit
that referenced
this pull request
Mar 3, 2021
Update usage of summary_fields for execution environments. Also, update unit-tests to cover this change. See: #8216
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update usage of summary_fields for execution environments. Also, update
unit-tests to cover this change.
See: #8216