Support Organization-scoped Galaxy installs #7817

ryanpetrello · 2020-08-04T17:47:23Z

curl -sk "https://awx.example.org/api/v2/organizations/1/galaxy_credentials/" | jq '.results[] | .inputs'
{
  "url": "https://cloud.redhat.com/api/automation-hub/",
  "token": "$encrypted$",
  "auth_url": "https://sso.redhat.com/auth/realms/redhat-external/protocol/openid-connect/token"
}
{
  "url": "https://galaxy.ansible.com/"
}

softwarefactory-project-zuul · 2020-08-04T17:55:45Z

Build succeeded.

awx-api-lint : SUCCESS in 2m 16s
awx-api : SUCCESS in 7m 04s
awx-ui : SUCCESS in 3m 37s
awx-ui-next : SUCCESS in 7m 35s
awx-swagger : SUCCESS in 8m 00s
awx-detect-schema-change : FAILURE in 8m 04s (non-voting)
awx-ansible-modules : SUCCESS in 2m 26s

ryanpetrello · 2020-08-04T18:08:52Z

awx/main/redact.py

-            exclude_list += [settings.PRIMARY_GALAXY_URL]
-        if settings.FALLBACK_GALAXY_SERVERS:
-            exclude_list += [server['url'] for server in settings.FALLBACK_GALAXY_SERVERS]
+        # TODO: replace this with the server URLs from proj.org.credentials


I still need to refactor this.

Actually, @AlanCoding I don't think we actually need this anymore at all - the point of this code is to filter HTTP basic auth creds out of URLs - starting w/ this PR we're only supporting tokens, so I don't actually think we need this anymore.

ryanpetrello · 2020-08-04T18:12:50Z

awx/settings/defaults.py

-# List of dicts of fallback (additional) Galaxy servers.  If configured, these
-# will be higher precedence than public Galaxy, but lower than primary Galaxy.
-# Available options: 'id', 'url', 'username', 'password', 'token', 'auth_url'
-FALLBACK_GALAXY_SERVERS = []


@wenottingham @AlanCoding I decided not to put this into the migration; I can't see where we ever actually documented this as a feature (it's not exposed in the API, either), and given the landscape of "Galaxy-like services" before now, I'd argue we can probably assume there's not (m)any people who've done this (unless you two know of any).

Depends on what folks like GTS are doing. But I think the new way of setting this up is more clear.

Nevermind, I decided to just support it and write some tests.

ryanpetrello · 2020-08-04T18:14:41Z

awx/ui/client/src/configuration/forms/jobs-form/configuration-jobs.form.js

@@ -74,31 +74,6 @@ export default ['i18n', function(i18n) {
            AWX_SHOW_PLAYBOOK_LINKS: {
                type: 'toggleSwitch',
            },
-            PRIMARY_GALAXY_URL: {


Look, @mabashian, I know JavaScript!

ryanpetrello · 2020-08-04T18:16:28Z

awx/main/tasks.py

-                env['ANSIBLE_GALAXY_SERVER_LIST'] = ','.join([server.get('id', 'unnamed') for server in galaxy_servers])
+
+        # build out env vars for Galaxy credentials (in order)
+        galaxy_server_list = []


@wenottingham @rebeccahhh @chrismeyersfsu @AlanCoding one behavioral change worth pointing out here is that for new installs and new Organizations (ignore old settings that get migrated on upgrade), the default behavior is "don't pull from galaxy.ansible.com by default". I think this is what I heard @wenottingham say he wanted - is that right?

We'd need to document this, but I'm OK with it

duly noted 👍

So this is the API behavior we landed on, but I think as a nicety in the UI, when you create a new org, we're talking about pre-filling the field to include Ansible Galaxy. So at the time users create an org, they are immediately given the choice to opt in/out of "community Galaxy" at org creation time. But if you're automating org creation (via e.g., the CLI or modules), you've got to explicit set these credentials up yourself to represent where you want to pull content from by default.

see: #7817 (comment)

ryanpetrello · 2020-08-04T18:25:47Z

awx/main/redact.py

@@ -12,23 +10,13 @@ class UriCleaner(object):

    @staticmethod
    def remove_sensitive(cleartext):
-        # exclude_list contains the items that will _not_ be redacted


There's not really anything to redact here (we don't support basic auth anymore).

Also, all our credentialing data is passed in via environment variables now (a token).

Here's some stdout that illustrates that these URLs render just fine without this code:

I'm a little unclear why were doing this in the first place, @AlanCoding:

d59d856

The point of this function is to take a giant blob of stdout and discover embedded URLs (printed by e.g., git) like:

https://USER:PASS@foo

...and turn them into https://*********@foo

Why would we ever want to whitelist Galaxy/Hub URLs to prevent that behavior? I don't think we need this code at all anymore since we're losing basic auth support, but I think it was flawed to start with.

If it was important we would have test coverage for it. Maybe I was going crazy, I'm not sure.

softwarefactory-project-zuul · 2020-08-04T18:33:33Z

Build succeeded.

awx-api-lint : SUCCESS in 1m 47s
awx-api : SUCCESS in 7m 06s
awx-ui : SUCCESS in 3m 46s
awx-ui-next : SUCCESS in 7m 22s
awx-swagger : SUCCESS in 8m 21s
awx-detect-schema-change : FAILURE in 8m 17s (non-voting)
awx-ansible-modules : SUCCESS in 2m 16s

softwarefactory-project-zuul · 2020-08-04T19:17:47Z

Build succeeded.

awx-api-lint : SUCCESS in 2m 09s
awx-api : SUCCESS in 7m 16s
awx-ui : SUCCESS in 3m 48s
awx-ui-next : SUCCESS in 8m 40s
awx-swagger : SUCCESS in 8m 14s
awx-detect-schema-change : FAILURE in 9m 55s (non-voting)
awx-ansible-modules : SUCCESS in 2m 12s

AlanCoding · 2020-08-04T19:46:24Z

awx/main/migrations/_galaxy.py

+    # by default, prior versions of AWX/Tower automatically pulled content
+    # from galaxy.ansible.com
+    public_galaxy_enabled = True
+    public_galaxy_setting = Setting.objects.filter(key='PUBLIC_GALAXY_ENABLED').first()


👍 nice, that's how I would have done this inside of migrations.

AlanCoding · 2020-08-04T19:54:06Z

awx/main/migrations/_galaxy.py

+                organization=org,
+                credential_type=galaxy_type,
+                inputs = {
+                    'url': 'https://galaxy.ansible.com/'


I'm a little confused by this in particular. What happens if you create a new organization after this migration has finished? What credentials does it have associated, and how does it go about doing Galaxy commands before the user has associated any credentials?

Also, why would each organization get a new public galaxy "credential"? Wouldn't all orgs just share the same credential? It's 1 URL.

Also, shouldn't the public Galaxy credential be visible to all users? In this implementation, it seems like it would only be visible to superusers.

I'm a little confused by this in particular. What happens if you create a new organization after this migration has finished? What credentials does it have associated...

None. We're changing the default behavior when you create new Organizations to not pull unofficial community content (cc @wenottingham in case I've misunderstood this).

Also, why would each organization get a new public galaxy "credential"? Wouldn't all orgs just share the same credential? It's 1 URL.

That might be a better way to do this. Who's allowed to edit that one global credential, though? How would we even represent that with our current RBAC model?

How would each org be able to use this credential without weird backend logic on org creation?

One potential solution - Galaxy creds must belong to an Org (not a team or user). I think that's pretty reasonable, because there's no context you'd use them other than via their ordered assignment to an Organization (which is something an Org Admin and higher would have exclusively have access to).

Another approach I like (which I've pushed to this PR) is to just introduce the concept of Credential.managed_by_tower, just like we did with CredentialType.managed_by_tower, and to have one global, non-editable Credential that represents galaxy.ansible.com

What happens if you create a new organization after this migration has finished? What credentials does it have associated, and how does it go about doing Galaxy commands before the user has associated any credentials?

Could all new organizations start with a default credential in their Galaxy credential list? The default credential could point to galaxy.ansible.com.

Alternatively (& I think this might be preferable to what I mentioned above):

We could address this by showing a clear error / warning message if the user tries to run a JT that needs to fetch content without having configured a usable content credential that the job can use. There's a variety of places we could surface such a message (e.g job details page).

Could all new organizations start with a default credential in their Galaxy credential list? The default credential could point to galaxy.ansible.com.

What I've discussed with @wenottingham @AlanCoding and @mabashian is just this - we're going to make it so that the Org Creation form pre-fills with "Ansible Galaxy".

AlanCoding · 2020-08-04T19:57:18Z

awx/main/migrations/_galaxy.py

+                credential_type=galaxy_type,
+                inputs=inputs
+            )
+            cred.save()


I am going to have a lot of RBAC questions that stem from this. Before we even get into any feature-specific discussions, does this correctly populate the credential's role fields and their parents/ancestors? I don't trust that it does in migrations.

You made the organization of the credential the same as the organization it gets associated. Do you intend to enforce this for new credentials?

Good questions - this is an area where our usage of a credential to represent "pull from galaxy.ansible.com" here is a little weird. It doesn't really make sense to create one of these credentials outside of the context of its association with at least one Organization (i.e.., there's no reason for somebody lower than Org Admin to make one of these, because they can't actually assign it to an Org).

does this correctly populate the credential's role fields and their parents/ancestors?

It seems like it does?

Out[8]: 'Ansible Galaxy' In [9]: Credential.objects.first().inputs Out[9]: {'url': 'https://galaxy.ansible.com/'} In [10]: Credential.objects.first().admin_role.ancestors.all() Out[10]: <QuerySet [<Role: Admin-36>, <Role: Admin-2>, <Role: Credential Admin-6>, <Role: System Administrator-1>]> In [12]: Credential.objects.first().admin_role.parents.all() Out[12]: <QuerySet [<Role: Credential Admin-6>, <Role: System Administrator-1>]>

wenottingham · 2020-08-04T20:24:24Z

docs/collections.md

+`/api/v2/organizations/N/galaxy_credentials/`.  Authentication
+via an API token is optional (i.e., https://galaxy.ansible.com/), but other
+content sources (such as Red Hat Ansible Automation Hub) require proper
+configuration of the Auth URL and Token.


I think onprem hub can do token only w/o auth URL.

My understanding is cloud.redhat.com is token + Auth URL (basically, a keycloak server), and that "on premise Automation Hub" is a URL and a token. In any event, the permutation of how you specify all of this is different for each implementation, which is why everything but the "URL" is optional.

cc @chrismeyersfsu @rebeccahhh do I have this right?

sounds right to me, on prem Automation Hub should be an API token and URL.
Also yes, it is true that each implementation is different and we do need those other fields to be optional.

softwarefactory-project-zuul · 2020-08-04T21:39:07Z

Build succeeded.

awx-api-lint : SUCCESS in 2m 04s
awx-api : SUCCESS in 6m 56s
awx-ui : SUCCESS in 3m 55s
awx-ui-next : SUCCESS in 8m 07s
awx-swagger : SUCCESS in 8m 37s
awx-detect-schema-change : FAILURE in 8m 29s (non-voting)
awx-ansible-modules : SUCCESS in 2m 38s

ryanpetrello · 2020-08-04T22:37:41Z

awx/main/tests/functional/test_galaxy_credential_migration.py

+        settings.FALLBACK_GALAXY_SERVERS = []
+    assert org.galaxy_credentials.count() == 3
+    creds = org.galaxy_credentials.all()
+    assert creds[0].name == 'Private Galaxy (https://example.org/)'


cc @AlanCoding @wenottingham @rebeccahhh @chrismeyersfsu

Highest precedence is "private Hub" aka PRIMARY_GALAXY_XXXXXX
...followed by anything in FALLBACK_GALAXY_SERVERS
...followed by galaxy.ansible.com iff PUBLIC_GALAXY_ENABLED is not explicitly set to False.

Yes?

not sure if we're using the terminology of FALLBACK but other than that yes, that all looks correct to me.
(and by not sure, I literally just don't know, it probably is 🤷‍♀️)

I debated not actually migrating these FALLBACK_GALAXY_SERVERS at all, because I'm not confident anybody actually uses them (they're not exposed in the API or documented anywhere that I can tell).

softwarefactory-project-zuul · 2020-08-04T22:42:57Z

Build succeeded.

awx-api-lint : SUCCESS in 1m 48s
awx-api : SUCCESS in 8m 04s
awx-ui : SUCCESS in 5m 35s
awx-ui-next : SUCCESS in 7m 32s
awx-swagger : SUCCESS in 7m 54s
awx-detect-schema-change : FAILURE in 7m 39s (non-voting)
awx-ansible-modules : SUCCESS in 2m 10s

see: ansible#7813

…laxy credential

doing this in the migration *before* any Organizations actually exist is stirring up RBAC dragons that I don't have time to fight this commit meanst that *new* installs will pre-create the default Galaxy (public) credential in create_preload_data, while *upgraded/migrations* installs will do so via the migration

Add the new credential type to the Credential page object and helper methods to manage the galaxy credentials for the Organization page object.

softwarefactory-project-zuul · 2020-09-01T17:59:17Z

Build succeeded.

awx-api-lint : SUCCESS in 2m 05s
awx-api : SUCCESS in 10m 54s
awx-ui : SUCCESS in 3m 42s
awx-ui-next : SUCCESS in 9m 45s
awx-swagger : SUCCESS in 7m 58s
awx-detect-schema-change : FAILURE in 10m 16s (non-voting)
awx-ansible-modules : SUCCESS in 2m 28s

chrismeyersfsu · 2020-09-09T13:41:58Z

awx/api/serializers.py

+            org is None
+        ):
+            raise serializers.ValidationError(_(
+                "Galaxy credentials must be owned by an Organization."


What if the org is deleted?

I don't want to muck with the credential organization set null behavior

awx/awx/main/models/credential/__init__.py

Lines 103 to 109 in f4af74d

organization = models.ForeignKey(

'Organization',

null=True,

default=None,

blank=True,

on_delete=models.CASCADE,

related_name='credentials',

So it would leave it null. I'm not too terribly bothered by that. As long as an org admin can still remove it, I'm okay with it.

(note there are 2 orgs in play here, the one who owns the credential and the one using the credential, I am talking about the ownership org being deleted)

chrismeyersfsu · 2020-09-09T13:44:17Z

awx/api/serializers.py

+            list(owner_fields) != ['organization']
+        ):
+            raise serializers.ValidationError({"organization": _(
+                "Galaxy credentials must be owned by an Organization."


Yes. @AlanCoding wants to do away with team ownership and this aligns.

chrismeyersfsu · 2020-09-09T13:49:19Z

awx/main/management/commands/create_preload_data.py

@@ -42,6 +42,16 @@ def handle(self, *args, **kwargs):
                                              },
                                              created_by=superuser)
                c.admin_role.members.add(superuser)
+                public_galaxy_credential = Credential(


I'm on my cell phone. I assume this only runs on fresh installs and the migration will create this otherwise.

Yep, here:

https://github.com/ansible/awx/pull/7817/files#diff-990db3abe66cd302b90fe644303d7879R50
https://github.com/ansible/awx/pull/7817/files#diff-137317559e46e7be3f56a14d5b5fe1e7R18-R20

unlikelyzero · 2020-09-09T14:02:15Z

Issues:

Add/ Edit Credential form does not list Organization as a required field when creating or editing an 'Ansible Galaxy/Automation Hub API Token' credential
In-line helper text for 'Ansible Galaxy/Automation Hub API Token' could be more helpful

Tests:
Can create an Ansible Galaxy/Automation Hub API Token credential type
Can create an Ansible Galaxy/Automation Hub API Token credential type configured for cloud.redhat
Can create an Ansible Galaxy/Automation Hub API Token credential type configured for an on-prem AH server
Can assign a Ansible Galaxy/Automation Hub API Token credentials to a new Organization
Can assign multiple Ansible Galaxy/Automation Hub API Token credentials to a new Organization
Can assign a Ansible Galaxy/Automation Hub API Token credentials to an existing Organization
Can assign multiple Ansible Galaxy/Automation Hub API Token credentials to an existing Organization
Can remove Ansible Galaxy/Automation Hub API Token credentials from an existing Organization
If a project cannot reach the first Ansible Galaxy/Automation Hub API Token credential server configured, it will fallback to the second Ansible Galaxy/Automation Hub API Token credential

AlanCoding · 2020-09-09T14:06:42Z

awx/main/models/credential/__init__.py

+ManagedCredentialType(
+    namespace='galaxy_api_token',
+    kind='galaxy',
+    name=ugettext_noop('Ansible Galaxy/Automation Hub API Token'),


These highly descriptive names are kind of messy from the user's perspective using the name to reference the object, from the CLI or the collection like

tower_credential: credential_type: "Ansible Galaxy/Automation Hub API Token"

but no change here makes a lot of sense. We might want to add an issue to reference credential types by namespace in the collection modules.

AlanCoding · 2020-09-09T14:18:41Z

awx/api/serializers.py

@@ -2674,6 +2694,14 @@ def validate(self, attrs):
        if attrs.get('team'):
            attrs['organization'] = attrs['team'].organization

+        if (
+            attrs['credential_type'].kind == 'galaxy' and


what if attrs['credential_type'] is null or the key is not present?

AlanCoding · 2020-09-09T14:23:31Z

awx/main/models/credential/__init__.py

+            'type': 'string',
+            'secret': True,
+            'help_text': ugettext_noop(
+                'A token to use for authentication against the Galaxy instance.'


To get legalistic with this - the token could be used for either Galaxy or Automation Hub, but the auth_url would only be used with Automation Hub.

AlanCoding · 2020-09-09T14:30:47Z

awx/main/tasks.py

-            'roles_enabled': settings.AWX_ROLES_ENABLED,
-            'collections_enabled': settings.AWX_COLLECTIONS_ENABLED,
+            'roles_enabled': galaxy_creds_are_defined and settings.AWX_ROLES_ENABLED,
+            'collections_enabled': galaxy_creds_are_defined and settings.AWX_COLLECTIONS_ENABLED,


I would predict users having trouble debugging this, and I would like to put a docs note for it.

@tvo318 just to throw out some initial statement and wording:

If an organization does not have any Galaxy credentials associated with it, it will not download roles or collections from requirements files. On creation of a new organization:

the UI will automatically associate the public Galaxy credential (for now, may change in later releases)

organizations created via the API need to have the public Galaxy credential added in order to make use of roles/collection requirements files.

AlanCoding · 2020-09-09T14:36:28Z

@john-westcott-iv recently added some tests to help keep the AWX collection up-to-date with the API, but for now related lists are out of scope of those checks (it is hard to determine what the editable relationships are)

Given the default API behavior, I do see a lot of value in making the corresponding collection update.

https://github.com/ansible/awx/blob/devel/awx_collection/plugins/modules/tower_organization.py

We would be adding the galaxy_credentials relationship as a list field. This can be modeled off a field like notification_templates_started.

Additionally, since the public Galaxy credential is statically named, I think we should add that to the examples for tower_organization, because the named reference will be universally correct.

Spitball:

- name: Create tower organization
  tower_organization:
    name: "My New Organization"
    description: "This has public galaxy enabled and will install roles and collections"
    galaxy_credentials:
      - Ansible Galaxy

softwarefactory-project-zuul · 2020-09-09T16:17:17Z

Build succeeded (gate pipeline).

awx-api-lint : SUCCESS in 2m 01s
awx-api : SUCCESS in 8m 01s
awx-ui : SUCCESS in 4m 45s
awx-ui-next : SUCCESS in 9m 18s
awx-swagger : SUCCESS in 9m 48s
awx-detect-schema-change : FAILURE in 1m 18s (non-voting)
awx-ansible-modules : SUCCESS in 2m 23s
awx-push-new-schema : SUCCESS in 8m 04s (non-voting)

ryanpetrello requested review from AlanCoding, jakemcdermott, elyezer, rebeccahhh and chrismeyersfsu August 4, 2020 17:48

ryanpetrello requested a review from mabashian August 4, 2020 18:08

ryanpetrello commented Aug 4, 2020

View reviewed changes

ryanpetrello force-pushed the galaxy-credentials branch 2 times, most recently from 5da4bfd to e6b29e3 Compare August 4, 2020 18:11

ryanpetrello commented Aug 4, 2020

View reviewed changes

ryanpetrello force-pushed the galaxy-credentials branch from e6b29e3 to 520dfb0 Compare August 4, 2020 18:17

ryanpetrello requested review from wenottingham and chouseknecht August 4, 2020 18:17

ryanpetrello changed the title ~~Support organization-scoped Galaxy credentials~~ Support organization-scoped Galaxy installs Aug 4, 2020

ryanpetrello changed the title ~~Support organization-scoped Galaxy installs~~ Support Organization-scoped Galaxy installs Aug 4, 2020

ryanpetrello requested a review from rooftopcellist August 4, 2020 18:21

ryanpetrello commented Aug 4, 2020

View reviewed changes

ryanpetrello force-pushed the galaxy-credentials branch from 6d89b96 to 9ec9499 Compare August 4, 2020 19:07

AlanCoding reviewed Aug 4, 2020

View reviewed changes

wenottingham reviewed Aug 4, 2020

View reviewed changes

ryanpetrello commented Aug 4, 2020

View reviewed changes

ryanpetrello and others added 14 commits September 1, 2020 13:44

add model support, an API, and a migration for Org -> Galaxy credentials

b8e0d08

see: ansible#7813

add a data migration for Galaxy credentials

130e279

see: ansible#7813

remove redaction exclusions for Galaxy URLs (basic auth support is gone)

25a9a9c

enforce Organization ownership of Galaxy credentials

1b4dd7c

properly migrate settings.FALLBACK_GALAXY_SERVERS

e5552b5

make a global "managed by AWX/Tower" Credential to represent Galaxy

011822b

Add a Galaxy Credential multi-select field to the Organizations form

458807c

update the help text for Organization galaxy credentials

30da93a

don't run ansible-galaxy installs if there are no Galaxy credentials

a30ca9c

Pre-populate organization galaxy credential field with the default ga…

895010c

…laxy credential

properly handle Galaxy credentials if a Project is orphaned

4046b18

Update awxkit to manage Org galaxy credentials

ad85b17

Add the new credential type to the Credential page object and helper methods to manage the galaxy credentials for the Organization page object.

renumber the Galaxy credential migration after rebasing

f4af74d

ryanpetrello force-pushed the galaxy-credentials branch from 163480a to f4af74d Compare September 1, 2020 17:48

chrismeyersfsu reviewed Sep 9, 2020

View reviewed changes

AlanCoding reviewed Sep 9, 2020

View reviewed changes

rooftopcellist approved these changes Sep 9, 2020

View reviewed changes

AlanCoding reviewed Sep 9, 2020

View reviewed changes

jakemcdermott approved these changes Sep 9, 2020

View reviewed changes

ryanpetrello added the mergeit label Sep 9, 2020

softwarefactory-project-zuul bot merged commit caa7b43 into ansible:devel Sep 9, 2020

elyezer mentioned this pull request Sep 9, 2020

Improve support for fetching content from multiple Galaxy-like endpoints #7813

Closed

8 tasks

ryanpetrello mentioned this pull request Oct 12, 2020

15.0.0 does not detect roles/requirements.yml #8341

Closed

	organization = models.ForeignKey(
	'Organization',
	null=True,
	default=None,
	blank=True,
	on_delete=models.CASCADE,
	related_name='credentials',

Support Organization-scoped Galaxy installs #7817

Support Organization-scoped Galaxy installs #7817

Conversation

ryanpetrello commented Aug 4, 2020 • edited Loading

softwarefactory-project-zuul bot commented Aug 4, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ryanpetrello Aug 4, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ryanpetrello Aug 5, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ryanpetrello Aug 4, 2020 • edited Loading

Choose a reason for hiding this comment

ryanpetrello Aug 4, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

softwarefactory-project-zuul bot commented Aug 4, 2020

softwarefactory-project-zuul bot commented Aug 4, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ryanpetrello Aug 4, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ryanpetrello Aug 4, 2020 • edited Loading

Choose a reason for hiding this comment

ryanpetrello Aug 5, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jakemcdermott Aug 5, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ryanpetrello Aug 4, 2020 • edited Loading

Choose a reason for hiding this comment

ryanpetrello Aug 4, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ryanpetrello Aug 4, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

softwarefactory-project-zuul bot commented Aug 4, 2020

ryanpetrello Aug 4, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

softwarefactory-project-zuul bot commented Aug 4, 2020

softwarefactory-project-zuul bot commented Sep 1, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ryanpetrello Sep 9, 2020 • edited Loading

Choose a reason for hiding this comment

unlikelyzero commented Sep 9, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

AlanCoding commented Sep 9, 2020

softwarefactory-project-zuul bot commented Sep 9, 2020

ryanpetrello commented Aug 4, 2020 •

edited

Loading

ryanpetrello Aug 4, 2020 •

edited

Loading

ryanpetrello Aug 5, 2020 •

edited

Loading

ryanpetrello Aug 4, 2020 •

edited

Loading

ryanpetrello Aug 4, 2020 •

edited

Loading

ryanpetrello Aug 4, 2020 •

edited

Loading

ryanpetrello Aug 4, 2020 •

edited

Loading

ryanpetrello Aug 5, 2020 •

edited

Loading

jakemcdermott Aug 5, 2020 •

edited

Loading

ryanpetrello Aug 4, 2020 •

edited

Loading

ryanpetrello Aug 4, 2020 •

edited

Loading

ryanpetrello Aug 4, 2020 •

edited

Loading

ryanpetrello Aug 4, 2020 •

edited

Loading

ryanpetrello Sep 9, 2020 •

edited

Loading

unlikelyzero commented Sep 9, 2020 •

edited

Loading