Adds disassociate functionality and an empty state for Sys Admin #7183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
259d778 to
cd0e7b7
Compare
|
Build succeeded.
|
cd0e7b7 to
45b9494
Compare
|
Build succeeded.
|
jlmitch5
approved these changes
Jun 2, 2020
| @@ -42,4 +47,23 @@ describe('<TeamAccessListItem/>', () => { | |||
| wrapper.find('PFDataListCell[aria-label="resource role"]').text() | |||
| ).toContain('Admin'); | |||
| }); | |||
| test('should actionable chip', () => { | |||
There was a problem hiding this comment.
this might better read "should render deletable chip"
| @@ -42,4 +44,23 @@ describe('<UserAccessListItem/>', () => { | |||
| wrapper.find('PFDataListCell[aria-label="resource role"]').text() | |||
| ).toContain('Admin'); | |||
| }); | |||
| test('should actionable chip', () => { | |||
45b9494 to
15d6c5f
Compare
|
Build succeeded.
|
dsesami
reviewed
Jun 2, 2020
| {i18n._(t`System Administrator`)} | ||
| </Title> | ||
| <EmptyStateBody> | ||
| {i18n._(t`System administrators have access to all permissions.`)} |
There was a problem hiding this comment.
Can we rephrase this? It's understandable, but I want to be more specific. How about "System administrators have full permissions and access".
dsesami
approved these changes
Jun 2, 2020
|
Build succeeded.
|
|
Build succeeded (gate pipeline).
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This addresses #7104 and #7102. It add's functionality to disassociate a role in user/team -> access
ISSUE TYPE
COMPONENT NAME
AWX VERSION
ADDITIONAL INFORMATION