Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable management job notications for admins #7042

Conversation

jakemcdermott
Copy link
Contributor

SUMMARY

Make the management job notification toggles enabled for admins. Relates to a bug in an external repo.

@jakemcdermott jakemcdermott force-pushed the fix-disabled-management-job-notifications branch from ae84d1e to 77dce8d Compare May 15, 2020 18:47
Copy link
Contributor

@jlmitch5 jlmitch5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good (nitpick, if there's a results[0] there should be a count, so I don't really know if that's super necessary, but I'm all for trying to guard this as much as possible so we don't have inadverdent bugs

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

@jakemcdermott jakemcdermott force-pushed the fix-disabled-management-job-notifications branch from 77dce8d to 257d1ee Compare May 15, 2020 19:03
@jakemcdermott jakemcdermott force-pushed the fix-disabled-management-job-notifications branch from 257d1ee to a66d44d Compare May 15, 2020 19:24
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 38f1393 into ansible:devel May 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants