-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable management job notications for admins #7042
Merged
softwarefactory-project-zuul
merged 1 commit into
ansible:devel
from
jakemcdermott:fix-disabled-management-job-notifications
May 18, 2020
Merged
Enable management job notications for admins #7042
softwarefactory-project-zuul
merged 1 commit into
ansible:devel
from
jakemcdermott:fix-disabled-management-job-notifications
May 18, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awx/ui/client/src/management-jobs/notifications/notification.controller.js
Outdated
Show resolved
Hide resolved
ae84d1e
to
77dce8d
Compare
jlmitch5
reviewed
May 15, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good (nitpick, if there's a results[0] there should be a count, so I don't really know if that's super necessary, but I'm all for trying to guard this as much as possible so we don't have inadverdent bugs
awx/ui/client/src/management-jobs/notifications/notification.route.js
Outdated
Show resolved
Hide resolved
jlmitch5
approved these changes
May 15, 2020
Build failed.
|
77dce8d
to
257d1ee
Compare
257d1ee
to
a66d44d
Compare
Build succeeded.
|
jlmitch5
approved these changes
May 18, 2020
Build succeeded (gate pipeline).
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Make the management job notification toggles enabled for admins. Relates to a bug in an external repo.