wsbroadcast better logging and behavior #6720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* We log stats using a safe hostname because of prometheus requirements. However, when we display users the hostname we should use the Instance hostname. This change outputs the Instance.hostname instead of the safe prometheus name.
* awx_manage run_wsbroadcast --status nice error message if someone failed to start awx services (i.e. redis)
|
Build succeeded.
|
| @@ -101,7 +108,7 @@ def handle(self, *arg, **options): | |||
| else: | |||
| data[family.name] = family.samples[0].value | |||
| me = Instance.objects.me() | |||
| hostnames = [i.hostname for i in Instance.objects.exclude(hostname=me.hostname)] | |||
| hostnames = [i.hostname for i in Instance.objects.exclude(Q(hostname=me.hostname) | Q(rampart_groups__controller__isnull=False))] | |||
ryanpetrello
approved these changes
Apr 15, 2020
|
Build failed (gate pipeline). For information on how to proceed, see
|
|
regate |
|
Build succeeded (gate pipeline).
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/var/log/tower/wsbroadcast.logfailed to start awx services (i.e. redis)