Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

properly respect REFRESH_TOKEN_EXPIRE_SECONDS when generating new tokens #6631

Merged
merged 1 commit into from
Apr 7, 2020
Merged

properly respect REFRESH_TOKEN_EXPIRE_SECONDS when generating new tokens #6631

merged 1 commit into from
Apr 7, 2020

Conversation

ryanpetrello
Copy link
Contributor

@ryanpetrello ryanpetrello commented Apr 7, 2020 •
edited
Loading

@ryanpetrello
Copy link
Contributor Author

There's probably some better fix for this in Django OAuth Toolkit itself, but given the age of the linked issue, and the severity of this issue, it's more important to get this fixed for now.

@ryanpetrello ryanpetrello force-pushed the refresh-token-expiry branch from 5ec5c1b to fbc60a5 Compare April 7, 2020 15:11
@ryanpetrello ryanpetrello requested a review from fosterseth April 7, 2020 15:13
matburt
matburt approved these changes Apr 7, 2020
View reviewed changes
Copy link
Member

@matburt matburt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM

@ryanpetrello ryanpetrello mentioned this pull request Apr 7, 2020
Closed
@ryanpetrello ryanpetrello force-pushed the refresh-token-expiry branch from fbc60a5 to 03d9153 Compare April 7, 2020 15:29
@ryanpetrello ryanpetrello force-pushed the refresh-token-expiry branch from 03d9153 to 0bf1116 Compare April 7, 2020 15:34
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 25a1bc7 into ansible:devel Apr 7, 2020
@tvo318 tvo318 mentioned this pull request Feb 21, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matburt matburt matburt approved these changes

@chrismeyersfsu chrismeyersfsu chrismeyersfsu approved these changes

@rooftopcellist rooftopcellist rooftopcellist approved these changes

@fosterseth fosterseth Awaiting requested review from fosterseth

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ryanpetrello @matburt @chrismeyersfsu @rooftopcellist