Remove field properties which are default values anyway #6472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
squidboylan
approved these changes
Mar 30, 2020
0c30ed3 to
8d46535
Compare
|
Build succeeded.
|
|
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
remove cases of required=False, the default remove str type specifier which, the default remove supports check mode, not changeable
|
Build succeeded.
|
|
Build succeeded (gate pipeline).
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
We inconsistently provided in some cases, and did not provide in other cases, these things.
Ansible core uses these as the defaults, so we don't have to put them in. I find it a whole lot more readable with them out. Our modules and API follows this pattern quite well - that the vast majority of parameters are non-required string-types. There's no need to say so each time.
ISSUE TYPE
AWX VERSION