Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix smart inventory duplicate hosts #5972

Merged
merged 1 commit into from
Mar 3, 2020
Merged

fix smart inventory duplicate hosts #5972

merged 1 commit into from
Mar 3, 2020

Conversation

jainnikhil30
Copy link
Contributor

SUMMARY

This fixes the issue where smart inventory pulls duplicate hosts, if the hosts is part of two different groups.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME
  • API

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

@AlanCoding
Copy link
Member

The only hesitation here is the problem of understanding why it was like that in the first place. Introduction:

eb6a276#diff-45e09d8d8eee985479682c26e972f8e3

I should also link #3133 here. Maybe this implies that we need some regression coverage from steps-to-reproduce in #3106.

Either way, I'm in favor of this PR.

@AlanCoding
Copy link
Member

Could you rebase this so we can test with latest fixes?

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

@AlanCoding AlanCoding requested a review from ryanpetrello March 3, 2020 15:30
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit c1bfcd7 into ansible:devel Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants