Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove two unused parent relationships from JobEvent model #5669

Merged
merged 1 commit into from
Jan 20, 2020
Merged

Remove two unused parent relationships from JobEvent model #5669

merged 1 commit into from
Jan 20, 2020

Conversation

AlanCoding
Copy link
Member

SUMMARY

These are no longer supported. Since there is no way for users to even get these populated with the correct data, there is no longer any argument for keeping them around.

#5618

#5618 (comment)

This method was dead code that nothing was calling. I can't see any evidence of its use since ~2014.

#5618 (comment)

Looks like it got turned off as default behavior years ago - 🤷‍♂

(setting to turn it back on was removed)

#3800

I would like to delete the job event children relationship, but do that separately from this. This PR is to restore functionality to this endpoint.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME
  • API
AWX VERSION
9.1.1

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

@ryanpetrello
Copy link
Contributor

ryanpetrello commented Jan 15, 2020 •
edited
Loading

If you don't mind, please hold off on merging this until I get #5448 in (soon) 😄

@AlanCoding
Copy link
Member Author

Oh sure, I'm not 100% finished with testing this. When I am I will squash commits and the 2 migrations.

ryanpetrello
ryanpetrello approved these changes Jan 15, 2020
View reviewed changes
Copy link
Contributor

@ryanpetrello ryanpetrello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming integration looks good, I'm fine with this 👍

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

@AlanCoding
Remove event hosts relationship
9a42082 
and parent event-event ForeignKey relationship
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

@AlanCoding
Copy link
Member Author

Finished triaging results, I'm good to merge this, @matburt any concerns from you?

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 03cfb7b into ansible:devel Jan 20, 2020
@matburt
Copy link
Member

matburt commented Jan 20, 2020

Sorry I missed this last week, it looks good by me.

@AlanCoding AlanCoding deleted the no_parent_or_host branch May 29, 2020 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryanpetrello ryanpetrello ryanpetrello approved these changes

@jakemcdermott jakemcdermott jakemcdermott approved these changes

@matburt matburt Awaiting requested review from matburt

@chrismeyersfsu chrismeyersfsu Awaiting requested review from chrismeyersfsu

Assignees
No one assigned
Labels
component:api type:enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@AlanCoding @ryanpetrello @matburt @jakemcdermott @awxbot