Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove inventory source update blocking #5519

Merged
merged 1 commit into from
Dec 19, 2019
Merged

Remove inventory source update blocking #5519

merged 1 commit into from
Dec 19, 2019

Conversation

fosterseth
Copy link
Member

SUMMARY

A running job that has an inventory update will block that update from running. This fix removes the block.

Adds a functional test that sets up a job in "running" state, and starts an inventory update that is in "pending" state. Using TaskManager::is_job_blocked and DependenceGraph::is_job_blocked, assert that the inventory update is allowed to run.

issue #4809

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME
  • API
AWX VERSION
awx: 9.0.1
ADDITIONAL INFORMATION

@fosterseth fosterseth changed the title Fix inv source blocking Remove inventory source update blocking Dec 16, 2019
@fosterseth fosterseth force-pushed the fix-inv-source-blocking branch 2 times, most recently from b9b888d to 08d3d8d Compare December 16, 2019 18:52
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

@fosterseth fosterseth closed this Dec 16, 2019
@fosterseth fosterseth force-pushed the fix-inv-source-blocking branch from 08d3d8d to 0052967 Compare December 16, 2019 20:13
@fosterseth
Prevent running jobs from blocking inventory updates
b26b8e7 
A running job that has an inventory source will block
that inventory update from running. This fix removes
the block.

The test creates a job in running state, and an inventory
update in pending state. The test asserts that the
task manager and dependency graph .is_job_blocked method
returns False for the inventory update (i.e. update can
run).

issue ansible#4809
@fosterseth fosterseth reopened this Dec 16, 2019
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 497f460 into ansible:devel Dec 19, 2019
@ryanpetrello ryanpetrello mentioned this pull request Jan 2, 2020
Closed
@fosterseth fosterseth mentioned this pull request Sep 11, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlanCoding AlanCoding AlanCoding approved these changes

Assignees
No one assigned
Labels
component:api type:enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fosterseth @AlanCoding @awxbot