Sanitize newlines out of survey option inputs #4868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build succeeded.
|
|
Build succeeded.
|
jbradberry
reviewed
Oct 1, 2019
jbradberry
reviewed
Oct 1, 2019
075b707 to
911e049
Compare
|
Build succeeded.
|
AlanCoding
reviewed
Oct 2, 2019
02d6ce2 to
1dbe977
Compare
rebeccahhh
commented
Oct 3, 2019
|
Build succeeded.
|
jbradberry
reviewed
Oct 4, 2019
jbradberry
reviewed
Oct 4, 2019
c46ff57 to
b602d46
Compare
|
Build succeeded.
|
AlanCoding
reviewed
Oct 4, 2019
b602d46 to
18f38bb
Compare
|
Build succeeded.
|
2633d15 to
54a15dd
Compare
|
Build failed.
|
AlanCoding
reviewed
Oct 8, 2019
54a15dd to
6d5487d
Compare
|
Build succeeded.
|
AlanCoding
reviewed
Oct 9, 2019
AlanCoding
approved these changes
Oct 9, 2019
6d5487d to
cc7c9eb
Compare
|
Build succeeded.
|
…kes a string, splits it up, and then eliminates any extra newlines, or just accepts alist. Extra newlines are sanitized out. Signed-off-by: Rebeccah <rhunter@redhat.com>
ryanpetrello
reviewed
Oct 9, 2019
| ))) | ||
| # if it's a multiselect or multiple choice, it must have coices listed | ||
| # choices and defualts must come in as strings seperated by /n characters. | ||
| if qtype == 'multiselect' or qtype == 'multiplechoice': |
There was a problem hiding this comment.
nitpick, but meh, po-tay-to po-tah-to
if qtype in ['multiplechoice', 'multiselect']:|
Build failed (gate pipeline). For information on how to proceed, see
|
|
have you rebased recently? anyone know what's up with in the UI target? |
|
Yeah #4932 merged 4 hours ago and introduced the target easiest solution should be to rebase against the devel branch. |
cc7c9eb to
7efacb6
Compare
|
@AlanCoding Darn, thought I had gotten those in before, rebased. |
|
Build succeeded.
|
|
regate |
|
Build succeeded.
|
AlanCoding
pushed a commit
to AlanCoding/awx
that referenced
this pull request
May 4, 2021
backport for fix for sat6 plugin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
pertains to #4452
The main issue here was the playbook itself, which was fixed, however it did expose the ability for a blank newline to be added to a survey, which will break it.
My changes have added in multiple choice options parsing, which takes the string, splits it up, and then eliminates any extra newlines (which had lead to the blank lines mentioned above).
Additionally wrote a small validation to prevent the API pushing a default value for a survey that is not in the list of available options.
Additionally edited mixins.py to cover the same scenario in the UI not just the API, however the issue #4866 persists.
ISSUE TYPE
COMPONENT NAME
AWX VERSION