Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Postgres 10 Upgrade #4058

Merged
merged 6 commits into from
Sep 12, 2019
Merged

Postgres 10 Upgrade #4058

merged 6 commits into from
Sep 12, 2019

Conversation

rooftopcellist
Copy link
Member

SUMMARY

This PR upgrades Postgres from 9.6 --> 10.

Related Issue: #3778 Upgrade to PostgreSQL 10 or 11

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME
  • API
  • Installer

@rooftopcellist rooftopcellist mentioned this pull request Jun 12, 2019
Closed
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

ryanpetrello
ryanpetrello reviewed Jun 12, 2019
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

@piroux
Copy link
Contributor

piroux commented Jun 18, 2019 •
edited
Loading

Hi !
For postgres, the pre-10 series released versions were following the X.y.z where X.y were the major part version and z the minor part.
Now with the post-10 released versions, they are following a new pattern X.y where X is the major and y the minor part.

According to their terminology:

We always recommend that all users run the latest available minor release for whatever major version is in use.

Major versions usually change the internal format of system tables and data files. These changes are often complex, so we do not maintain backward compatibility of all stored data. A dump/reload of the database or use of the pg_upgrade module is required for major upgrades. We also recommend reading the upgrading section of the major version you are planning to upgrade to.

Upgrading to a minor release does not normally require a dump and restore; you can stop the database server, install the updated binaries, and restart the server. For some releases, manual changes may be required to complete the upgrade, so always read the release notes before upgrading.

While upgrading will always contain some level of risk, PostgreSQL minor releases fix only frequently-encountered bugs, security issues, and data corruption problems to reduce the risk associated with upgrading. For minor releases, the community considers not upgrading to be riskier than upgrading.

https://www.postgresql.org/support/versioning/

All this to say: if the previously chosen tag was 9.6, only major without minor, I think we might as well continue to only set the major version, so that it would be 10 now and not 10.6.

@rooftopcellist
Copy link
Member Author

@piroux We have chosen to pin to the minor release of PostgreSQL 10.6 to maintain a consistent minor version across all of our supported platforms, as some platforms are currently locked in at 10.6.

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

@rooftopcellist
Copy link
Member Author

recheck

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

joseorpa and others added 3 commits September 12, 2019 12:52
@joseorpa @rooftopcellist
ansible#3778 Upgrading postgresql to v10
04ab736
@rooftopcellist
Upgrade to postgres 10.6
ec1e93c 
  - use awx-python in shebang in dev env
  - scl enable where needed for rhel7 & container installs
  - use scram-sha-256 pg user hashing by default
  - ensure psycopg2 is using the correct PG_CONFIG at build time for the right libpq version
@shanemcd @rooftopcellist
Implement local docker pg upgrade
0365678
@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

@shanemcd
Add scl enable back to start_tests script
b2e8e3c 
I think we need to specify the entrypoint in the pod definition too
@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

@shanemcd
Copy link
Member

recheck

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 70057bc into ansible:devel Sep 12, 2019
This was referenced Sep 12, 2019
Closed
Merged
@Klaas-
Copy link
Contributor

Klaas- commented Sep 23, 2019

Are there any upgrade docs planned? There is https://github.com/sclorg/postgresql-container/tree/generated/10#upgrading-database-by-switching-to-newer-postgresql-image-version for the pg containers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wenottingham wenottingham wenottingham left review comments

@AlanCoding AlanCoding AlanCoding left review comments

@shanemcd shanemcd shanemcd approved these changes

@ryanpetrello ryanpetrello ryanpetrello approved these changes

Assignees
No one assigned
Labels
component:api component:installer type:enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@rooftopcellist @piroux @Klaas- @ryanpetrello @shanemcd @AlanCoding @wenottingham @awxbot @joseorpa