Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish image base on git repo name instead of hard coded to AWX #15828

Merged

Conversation

TheRealHaoLiu
Copy link
Member

SUMMARY

Publish image base on git repo name instead of hard coded to AWX

ISSUE TYPE
  • Bug, Docs Fix or other nominal change
COMPONENT NAME
  • Other
AWX VERSION

ADDITIONAL INFORMATION

@TheRealHaoLiu TheRealHaoLiu marked this pull request as ready for review February 10, 2025 18:49
Copy link

codecov bot commented Feb 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.29%. Comparing base (7d2b2d6) to head (4316ff4).
Report is 1 commits behind head on devel.

✅ All tests successful. No failed tests found.

@AlanCoding
Copy link
Member

I need this documented as to why the change is happening

https://github.com/ansible/tower/pkgs/container/awx_devel

this awx_devel seems to be fine. It pushes 4.6 images. However it still shows the awx repo, confusingly.

https://github.com/ansible/tower/pkgs/container/awx

This just kind of doesn't work at all. It doesn't get the 4.6 image pushed up, matching with error messages you saw in the actions output.

Copy link
Member

@AlanCoding AlanCoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs updates in more places

run: docker pull -q ghcr.io/${OWNER_LC}/awx_devel:${{ github.base_ref || github.ref_name }}

@TheRealHaoLiu TheRealHaoLiu enabled auto-merge (squash) February 10, 2025 19:59
@TheRealHaoLiu TheRealHaoLiu enabled auto-merge (squash) February 10, 2025 19:59
@TheRealHaoLiu TheRealHaoLiu merged commit e7440c6 into ansible:devel Feb 10, 2025
23 of 26 checks passed
TheRealHaoLiu added a commit to TheRealHaoLiu/awx that referenced this pull request Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants