Use awx-plugins-shared code from awx_plugins.interfaces
#15566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webknjaz
commented
Oct 1, 2024
0d1cb7d to
2fc2bfc
Compare
The original function name was `server_product_name()` but it didn't really represent what it did. So it was renamed into `detect_server_product_name()` in an attempt of disambiguation.
The original function `to_container_path` has been renamed into `get_incontainer_path()` to represent what it does better and make the imports more obvious.
2fc2bfc to
dee7cd9
Compare
TheRealHaoLiu
approved these changes
Oct 2, 2024
auto-merge was automatically disabled
October 2, 2024 18:21
Head branch was pushed to by a user without write access
|
djyasin
pushed a commit
to djyasin/awx
that referenced
this pull request
Nov 11, 2024
) * Add `awx_plugins.interfaces` runtime dependency * Use `awx_plugins.interfaces` for runtime detection The original function name was `server_product_name()` but it didn't really represent what it did. So it was renamed into `detect_server_product_name()` in an attempt of disambiguation. * Use `awx_plugins.interfaces` to map container path The original function `to_container_path` has been renamed into `get_incontainer_path()` to represent what it does better and make the imports more obvious. * Add license file for awx_plugins.interfaces --------- Co-authored-by: Hao Liu <44379968+TheRealHaoLiu@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This contributes to removing the circular dependency between
awx-plugins-coreandawx.ADDITIONAL INFORMATION
The related PRs are:
awx_plugins.interfaces, not awx awx-plugins#38 (sibling)