Register system again if deleted by another pod #12494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlanCoding
commented
Jul 8, 2022
| self.instance_name = Instance.objects.me().hostname | ||
| except Exception as e: | ||
| self.instance_name = settings.CLUSTER_HOST_ID | ||
| logger.info(f'Instance {self.instance_name} seems to be unregistered, error: {e}') |
There was a problem hiding this comment.
@fosterseth help me out here please. This subsystem metrics code is front-running a million other scenarios by throwing an exception before we get deeper into the service details. For an example, we have this log which is beautifully constructed:
tools_awx_1 | 2022-07-08 17:40:57,095 INFO [-] awx.main.wsbroadcast Unable to return currently active instance: No instance found with the current cluster host id, retry in 5s...
tools_awx_1 | make[1]: Leaving directory '/awx_devel'
tools_awx_1 | 2022-07-08 17:41:02,473 INFO exited: awx-wsbroadcast (exit status 0; expected)
tools_awx_1 | 2022-07-08 17:41:03,477 INFO spawned: 'awx-wsbroadcast' with pid 27242
tools_awx_1 | make[1]: Entering directory '/awx_devel'
tools_awx_1 | 2022-07-08 17:41:04,498 INFO success: awx-wsbroadcast entered RUNNING state, process has stayed up for > than 1 seconds (startsecs)
tools_awx_1 | 2022-07-08 17:41:05,510 INFO [-] awx.main.wsbroadcast Unable to return currently active instance: No instance found with the current cluster host id, retry in 5s...
tools_awx_1 | make[1]: Leaving directory '/awx_devel'
tools_awx_1 | 2022-07-08 17:41:10,892 INFO exited: awx-wsbroadcast (exit status 0; expected)
tools_awx_1 | 2022-07-08 17:41:10,894 INFO spawned: 'awx-wsbroadcast' with pid 27275
tools_awx_1 | make[1]: Entering directory '/awx_devel'
tools_awx_1 | 2022-07-08 17:41:11,903 INFO success: awx-wsbroadcast entered RUNNING state, process has stayed up for > than 1 seconds (startsecs)
tools_awx_1 | 2022-07-08 17:41:12,996 INFO [-] awx.main.wsbroadcast Unable to return currently active instance: No instance found with the current cluster host id, retry in 5s...
I can get this if I suppress errors from the code here, as I'm trying to do here.
But this begs the obvious question, why do this at all? Why did we not start out referencing settings.CLUSTER_HOST_ID? We don't need the model, just the name. Did we get ourselves into this situation by cargo-culting the Instance.objects.me() call?
Avoid cases where missing instance would throw error on startup this gives time for heartbeat to register it
kdelee
approved these changes
Aug 15, 2022
CFSNM
approved these changes
Aug 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Solution for #12471
As of opening this, I can confirm it works, but causes churn in some other services.
ISSUE TYPE
COMPONENT NAME