-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolves issue where FireFox users could not schedule a job template #10291
Resolves issue where FireFox users could not schedule a job template #10291
Conversation
Build succeeded.
|
value={dateField.value.split('T')[0]} | ||
onChange={onDateChange} | ||
/> | ||
<TimePicker |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the default time picker placeholder is a bit confusing since it doesn't actually match up character for character with the format. I wonder if we change it to something like hh:mm AM/PM
if that would help folks know what the format is (if they're typing it in). This probably isn't a huge deal for us since we always have a default value set but I found this confusing the first time I played with this component. I thought it was expecting time in a 24 hour clock syntax like 21:45
instead of 09:45 PM
.
2c7ec14
to
347884c
Compare
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
347884c
to
16c6e2d
Compare
Build succeeded.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Build succeeded (gate pipeline).
|
SUMMARY
This addresses #10152 and #6214
ISSUE TYPE
COMPONENT NAME
ADDITIONAL INFORMATION