Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolves issue where FireFox users could not schedule a job template #10291

Conversation

AlexSCorey
Copy link
Member

@AlexSCorey AlexSCorey commented May 26, 2021

SUMMARY

This addresses #10152 and #6214

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME
  • UI
ADDITIONAL INFORMATION

Screen Shot 2021-05-26 at 3 47 16 PM

@AlexSCorey AlexSCorey requested a review from mabashian May 26, 2021 19:49
@AlexSCorey AlexSCorey changed the title uses pf date and time picker to schedule form Uses pf date and time picker on schedule form May 26, 2021
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

@AlexSCorey AlexSCorey changed the title Uses pf date and time picker on schedule form Resolves issue where FireFox users could not schedule a job template Jun 4, 2021
value={dateField.value.split('T')[0]}
onChange={onDateChange}
/>
<TimePicker
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the default time picker placeholder is a bit confusing since it doesn't actually match up character for character with the format. I wonder if we change it to something like hh:mm AM/PM if that would help folks know what the format is (if they're typing it in). This probably isn't a huge deal for us since we always have a default value set but I found this confusing the first time I played with this component. I thought it was expecting time in a 24 hour clock syntax like 21:45 instead of 09:45 PM.

@AlexSCorey AlexSCorey force-pushed the 10152-AddsPFDatePicker-v2 branch from 2c7ec14 to 347884c Compare June 8, 2021 13:31
@softwarefactory-project-zuul
Copy link
Contributor

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.

@AlexSCorey AlexSCorey force-pushed the 10152-AddsPFDatePicker-v2 branch from 347884c to 16c6e2d Compare June 8, 2021 14:33
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

Copy link
Contributor

@tiagodread tiagodread left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now the datepicker component can be successfully rendered in Chrome or Firefox.

Verified that:

  • Users can edit schedules created by the old component
  • Users can create/edit schedules
  • Jobs can be launched by a schedule

image

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants