Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cloud.common: temp turn k8s check non voting #1176

Merged
merged 1 commit into from
Oct 12, 2021
Merged

cloud.common: temp turn k8s check non voting #1176

merged 1 commit into from
Oct 12, 2021

Conversation

goneri
Copy link
Collaborator

@goneri goneri commented Oct 12, 2021

Temporarily disable ansible-test-molecule-kubernetes-core-with-turbo until
we land ansible-collections/cloud.common#92.

Temporarily disable ansible-test-molecule-kubernetes-core-with-turbo until
we land ansible-collections/cloud.common#92.
@goneri goneri changed the title cloud.common: temp turn k8s check non votin cloud.common: temp turn k8s check non voting Oct 12, 2021
@goneri goneri added the gate label Oct 12, 2021
Copy link
Contributor

@ansible-zuul ansible-zuul bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ansible-zuul ansible-zuul bot merged commit 20f0173 into ansible:master Oct 12, 2021
ansible-zuul bot pushed a commit to ansible-collections/cloud.common that referenced this pull request Oct 12, 2021
Fix parameters with aliases not being passed

Depends-On: ansible/ansible-zuul-jobs#1176
SUMMARY

The recently added _is_an_alias() function should check whether the
current key is in the list of aliases.

Fixes: #91
ISSUE TYPE


Bugfix Pull Request

COMPONENT NAME

ADDITIONAL INFORMATION

Reviewed-by: None <None>
Reviewed-by: Gonéri Le Bouder <goneri@lebouder.net>
ansible-zuul bot pushed a commit that referenced this pull request Oct 18, 2021
Revert "cloud.common: temp turn k8s check non votin (#1176)"

Depends-On: ansible-collections/cloud.common#92
Depends-On: ansible-collections/kubernetes.core#261
This reverts commit 20f0173 introduced by #1176.

Reviewed-by: None <None>
@goneri goneri deleted the cloud.common-temp-turn-k8s-check-non-votin_20800 branch December 13, 2021 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant