-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make ansible-test-splitter configuration more flexible (use getopts) #1014
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 28, 2021
4252d76
to
652fdea
Compare
7a9d005
to
750f75f
Compare
ansible-zuul bot
added a commit
to ansible-collections/community.aws
that referenced
this pull request
Aug 3, 2021
Update remaining _info modules so that they run in check_mode SUMMARY Update remaining _info modules so that they run in check_mode https://github.com/ansible-collections/overview/blob/main/collection_requirements.rst#development-conventions https://docs.ansible.com/ansible/devel/dev_guide/developing_modules_best_practices.html#following-ansible-conventions fixes: #659 ISSUE TYPE Feature Pull Request COMPONENT NAME aws_sgw_info ec2_asg_info ec2_lc_info iam_mfa_device_info iam_server_certificate_info wafv2_resources_info wafv2_web_acl_info ADDITIONAL INFORMATION cc: @felixfontein It would be good to get this in before the upcoming sanity check: ansible/ansible#75324 amazon.aws/pull/405 Depends-on: ansible/ansible-zuul-jobs#1014 Reviewed-by: Markus Bergholz <git@osuv.de> Reviewed-by: Felix Fontein <None> Reviewed-by: None <None>
ansible-zuul bot
added a commit
to ansible-collections/amazon.aws
that referenced
this pull request
Aug 27, 2021
Promote ec2 vpc igw SUMMARY Migrate ec2_vpc_igw* modules and tests ISSUE TYPE Feature Pull Request COMPONENT NAME ec2_vpc_igw, ec2_vpc_igw_info Depends-On: ansible/ansible-zuul-jobs/pull/1014 Reviewed-by: Mark Chappell <None> Reviewed-by: Mike Graves <mgraves@redhat.com> Reviewed-by: None <None>
ansible-zuul bot
added a commit
to ansible-collections/amazon.aws
that referenced
this pull request
Aug 27, 2021
Promote ec2 vpc route table SUMMARY Migrate ec2_vpc_route_table* modules and tests ISSUE TYPE Feature Pull Request COMPONENT NAME ec2_vpc_route_table, ec2_vpc_route_table_info Depends-On: ansible/ansible-zuul-jobs/pull/1014 Reviewed-by: Mark Chappell <None> Reviewed-by: None <None>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
…_mode Update remaining _info modules so that they run in check_mode SUMMARY Update remaining _info modules so that they run in check_mode https://github.com/ansible-collections/overview/blob/main/collection_requirements.rst#development-conventions https://docs.ansible.com/ansible/devel/dev_guide/developing_modules_best_practices.html#following-ansible-conventions fixes: ansible-collections#659 ISSUE TYPE Feature Pull Request COMPONENT NAME aws_sgw_info ec2_asg_info ec2_lc_info iam_mfa_device_info iam_server_certificate_info wafv2_resources_info wafv2_web_acl_info ADDITIONAL INFORMATION cc: @felixfontein It would be good to get this in before the upcoming sanity check: ansible/ansible#75324 amazon.aws/pull/405 Depends-on: ansible/ansible-zuul-jobs#1014 Reviewed-by: Markus Bergholz <git@osuv.de> Reviewed-by: Felix Fontein <None> Reviewed-by: None <None>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integration tests can be slow. For the amazon.aws checks we only want to run the full integration tests as a part of gate. "check" should run only on the tests for modules that changed.