-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cap the version Sphinx
below 4.4.0
#775
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
cidrblock
approved these changes
Jan 19, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
webknjaz
changed the title
chore: pin down sphinx < 4.4.0
Cap the version Jan 19, 2022
Sphinx
below 4.4.0
webknjaz
reviewed
Jan 19, 2022
Co-authored-by: Sviatoslav Sydorenko <webknjaz@redhat.com>
@ssbarnea please fill out the PR description with something more meaningful than a contextless reference to another location. |
I am responsible for the poor description here. |
cidrblock
pushed a commit
to cidrblock/ansible-navigator
that referenced
this pull request
Jan 19, 2022
Cap the version `Sphinx` below 4.4.0 The latest version of sphinx was causing the following errors, and therefore is being capped to version prior to the version causing the errors. /home/docs/checkouts/readthedocs.org/user_builds/ansible-navigator/checkouts/774/docs/changelog.md:16: WARNING: hardcoded link 'https://github.com/twisted/towncrier' could be replaced by an extlink (try using ':gh:`twisted/towncrier`' instead) /home/docs/checkouts/readthedocs.org/user_builds/ansible-navigator/checkouts/774/docs/installation.md:3: WARNING: hardcoded link 'containers/podman#8016' could be replaced by an extlink (try using ':gh:`containers/podman/issues/8016`' instead) Detailed information about the changes introduced in sphinx causing the errors can be found here: Related: sphinx-doc/sphinx#10112 The following issue was created to revert this PR once the sphinx error is fixed or can be avoided: See ansible#776 Reviewed-by: Bradley A. Thornton <bthornto@redhat.com> Reviewed-by: None <None> Reviewed-by: Sviatoslav Sydorenko <webknjaz+github/profile@redhat.com>
cidrblock
pushed a commit
to cidrblock/ansible-navigator
that referenced
this pull request
Jan 20, 2022
Cap the version `Sphinx` below 4.4.0 The latest version of sphinx was causing the following errors, and therefore is being capped to version prior to the version causing the errors. /home/docs/checkouts/readthedocs.org/user_builds/ansible-navigator/checkouts/774/docs/changelog.md:16: WARNING: hardcoded link 'https://github.com/twisted/towncrier' could be replaced by an extlink (try using ':gh:`twisted/towncrier`' instead) /home/docs/checkouts/readthedocs.org/user_builds/ansible-navigator/checkouts/774/docs/installation.md:3: WARNING: hardcoded link 'containers/podman#8016' could be replaced by an extlink (try using ':gh:`containers/podman/issues/8016`' instead) Detailed information about the changes introduced in sphinx causing the errors can be found here: Related: sphinx-doc/sphinx#10112 The following issue was created to revert this PR once the sphinx error is fixed or can be avoided: See ansible#776 Reviewed-by: Bradley A. Thornton <bthornto@redhat.com> Reviewed-by: None <None> Reviewed-by: Sviatoslav Sydorenko <webknjaz+github/profile@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest version of sphinx was causing the following errors, and therefore is being capped to version prior to the version causing the errors.
Detailed information about the changes introduced in sphinx causing the errors can be found here:
Related: sphinx-doc/sphinx#10112
The following issue was created to revert this PR once the sphinx error is fixed or can be avoided:
See #776