-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Conversation
add zabbix modules for groups, hosts screens and webchecks
else: | ||
module.exit_json(changed=False) | ||
|
||
#<<INCLUDE_ANSIBLE_MODULE_COMMON>> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this boilerplate is deprecated (also see http://docs.ansible.com/developing_modules.html#common-module-boilerplate), you should use
from ansible.module_utils.basic import *
main()
thanks @resmo, updated. |
@cove they merged my zabbix_group module. I am asking to revert it, so this can be pulled in. |
import random | ||
import time | ||
|
||
from ansible.module_utils.basic import * |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove this line, duplicate of https://github.com/ansible/ansible-modules-extras/pull/44/files#diff-52e41b51661c5ff9d2854b88d297d200R391
This reverts commit 95b660f.
@resmo sounds good, thanks for helping review. |
Can you make this a separate request per module, its easier to review and add individually. i'm guessing the rebase is needed because of the zabbix_group module we already merged |
* major redo of doc generation * major redo of doc generation Change-Id: Ic46dbc4ae1431a9ac882c88fbf0af56dd8b40d9a * Fix typo on get_pools vs ex_get_pools Change-Id: I478e06ac8ef7b129e894c31b8b23e1ad702a5cf7
* major redo of doc generation * major redo of doc generation Change-Id: Ic46dbc4ae1431a9ac882c88fbf0af56dd8b40d9a * Fix typo on get_pools vs ex_get_pools Change-Id: I478e06ac8ef7b129e894c31b8b23e1ad702a5cf7
* major redo of doc generation * major redo of doc generation Change-Id: Ic46dbc4ae1431a9ac882c88fbf0af56dd8b40d9a * Fix typo on get_pools vs ex_get_pools Change-Id: I478e06ac8ef7b129e894c31b8b23e1ad702a5cf7
* major redo of doc generation * major redo of doc generation Change-Id: Ic46dbc4ae1431a9ac882c88fbf0af56dd8b40d9a * Fix typo on get_pools vs ex_get_pools Change-Id: I478e06ac8ef7b129e894c31b8b23e1ad702a5cf7
add zabbix modules for groups, hosts screens and webchecks