Skip to content
This repository has been archived by the owner on Oct 30, 2018. It is now read-only.

add zabbix modules #44

Closed
wants to merge 7 commits into from
Closed

add zabbix modules #44

wants to merge 7 commits into from

Conversation

cove
Copy link
Contributor

@cove cove commented Oct 2, 2014

add zabbix modules for groups, hosts screens and webchecks

add zabbix modules for groups, hosts screens and webchecks
else:
module.exit_json(changed=False)

#<<INCLUDE_ANSIBLE_MODULE_COMMON>>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this boilerplate is deprecated (also see http://docs.ansible.com/developing_modules.html#common-module-boilerplate), you should use

from ansible.module_utils.basic import *
main()

@cove
Copy link
Contributor Author

cove commented Dec 14, 2014

thanks @resmo, updated.

@resmo
Copy link
Contributor

resmo commented Dec 15, 2014

@cove they merged my zabbix_group module. I am asking to revert it, so this can be pulled in.

import random
import time

from ansible.module_utils.basic import *
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cove
Copy link
Contributor Author

cove commented Dec 15, 2014

@resmo sounds good, thanks for helping review.

@bcoca
Copy link
Member

bcoca commented Mar 26, 2015

Can you make this a separate request per module, its easier to review and add individually.

i'm guessing the rebase is needed because of the zabbix_group module we already merged
@resmo I did not see your request to defer to these modules.

@cove
Copy link
Contributor Author

cove commented Mar 28, 2015

re-submitted as #343, #344, #345 and #346

NB: the zabbix_webcheck module is no longer needed in recent versions of zabbix, the zabbix_hostmacro module is used instead.

@cove cove closed this Mar 28, 2015
aimonb added a commit to DimensionDataResearch/ansible-modules-extras that referenced this pull request Aug 12, 2016
* major redo of doc generation

* major redo of doc generation

Change-Id: Ic46dbc4ae1431a9ac882c88fbf0af56dd8b40d9a

* Fix typo on get_pools vs ex_get_pools

Change-Id: I478e06ac8ef7b129e894c31b8b23e1ad702a5cf7
aimonb added a commit to DimensionDataResearch/ansible-modules-extras that referenced this pull request Sep 8, 2016
* major redo of doc generation

* major redo of doc generation

Change-Id: Ic46dbc4ae1431a9ac882c88fbf0af56dd8b40d9a

* Fix typo on get_pools vs ex_get_pools

Change-Id: I478e06ac8ef7b129e894c31b8b23e1ad702a5cf7
relaxdiego pushed a commit to DimensionDataResearch/ansible-modules-extras that referenced this pull request Sep 15, 2016
* major redo of doc generation

* major redo of doc generation

Change-Id: Ic46dbc4ae1431a9ac882c88fbf0af56dd8b40d9a

* Fix typo on get_pools vs ex_get_pools

Change-Id: I478e06ac8ef7b129e894c31b8b23e1ad702a5cf7
relaxdiego pushed a commit to DimensionDataResearch/ansible-modules-extras that referenced this pull request Sep 15, 2016
* major redo of doc generation

* major redo of doc generation

Change-Id: Ic46dbc4ae1431a9ac882c88fbf0af56dd8b40d9a

* Fix typo on get_pools vs ex_get_pools

Change-Id: I478e06ac8ef7b129e894c31b8b23e1ad702a5cf7
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants