Prevent failing on duplicate pushes to TestPyPI @ GHA #857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssbarnea
reviewed
Jun 24, 2020
|
I had a similar issue today and I think I found a better way to avoid duplicates. Also look at setup.py |
ssbarnea
approved these changes
Jun 30, 2020
This change addresses the case when there's two workflow runs for the same commit triggered via different events. Like `push` and `create`. In this case, publishing to PyPI may fail because both would generate dists with the same version causing a conflict on upload.
This reverts commit a7a0d7e.
1ccdcc0 to
1f1d561
Compare
This change will produce versions that equal to tags only on tag creation events while all other events won't take that tag into account. Such an approach allows us to avoid race conditions arising from pushing Git tags around the same time as pushing the corresponding commits to master. Both workflows will then have access to the tag on the current commit and setuptools-scm would generate the same version which would explode during publishing to TestPyPI. Non-tag-creation workflows remove any tags from HEAD after checkout making the generated version for those builds be based on the previous tag in the branch.
1f1d561 to
9576b58
Compare
webknjaz
added a commit
that referenced
this pull request
Jun 30, 2020
This is needed to address a regression introduced by #857. Doing `git fetch --depth=1` makes the repo shallow again and combined with all tags removed from `HEAD` it tricks `setuptools_scm` to return v0.1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change addresses the case when there's two workflow runs
for the same commit triggered via different events. Like
pushand
create. In this case, publishing to PyPI may fail becauseboth would generate dists with the same version causing a
conflict on upload.